testing: use a real terminal in test Test Results view #184963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Jun 13, 2023
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/terminal/browser/xterm/xtermTerminal.ts
Outdated
Show resolved
Hide resolved
connor4312
force-pushed
the
testing-ansi-support
branch
from
9290ea3
to
6dc393c
Compare
connor4312
force-pushed
the
testing-ansi-support
branch
from
6dc393c
to
714e6b6
Compare
connor4312
force-pushed
the
testing-ansi-support
branch
from
bf8bcd3
to
1f3b6d6
Compare
Tyriar
requested changes
Jun 15, 2023
Comment on lines
+376
to
+378
| if (e.browserEvent?.defaultPrevented) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
What's this change for? Worried about regressions
There was a problem hiding this comment.
xterm correctly calls .preventDefault() if a scroll event gets handled by the terminal, but this wasn't respected by the editor. This resulted in scrolling within the terminal when it's shown in the inline peek to scroll the editor when it should instead have just scrolled the terminal.
I'm guessing this is the first time we have something in the editor that manually handles scrolling, so this check was missing.
Tyriar
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #151964
Shows test output in a real terminal. Adds a new notion of a 'detached' XtermTerminal instance that's used to show a terminal here. It also wires up a subset of terminal commands to work in the terminal. Currently I have assumed such detached terminals will always be read-only.