-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update to Electron 25 #188268
Merged
Merged
chore: update to Electron 25 #188268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepak1556
force-pushed
the
electron-25.x.y
branch
3 times, most recently
from
July 19, 2023 14:21
392dd63
to
5717d25
Compare
do you have an ETA for this ? |
deepak1556
force-pushed
the
electron-25.x.y
branch
11 times, most recently
from
July 27, 2023 10:56
4050547
to
20ad537
Compare
deepak1556
force-pushed
the
electron-25.x.y
branch
2 times, most recently
from
July 31, 2023 14:01
f8f6faa
to
28a8c1f
Compare
Closed
deepak1556
force-pushed
the
electron-25.x.y
branch
6 times, most recently
from
August 7, 2023 03:29
cb1169e
to
93d3731
Compare
deepak1556
force-pushed
the
electron-25.x.y
branch
from
August 7, 2023 09:48
93d3731
to
8456050
Compare
bpasero
previously approved these changes
Aug 7, 2023
bpasero
approved these changes
Aug 7, 2023
I'm getting a segfault on the latest insider release but it failed to write a crash dump:
What's the best way to get a crash dump so I could file an issue? |
You can follow the steps here https://github.com/microsoft/vscode/wiki/Native-Crash-Issues#creating-a-crash-report to get the crash logs, thanks! |
@deepak1556 I made #189956. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #184021
Fixes #189384
Fixes #188769
Fixes #188757