Update to Electron 25 #184021

deepak1556 · 2023-06-01T07:12:28Z

Todo

Give feedback

Update patches
Nightly Exploration builds
Update native modules
Update/Check LICENSE file in CG for new node.js version
Update LICENSE for new ffmpeg version
Node 18 bumps minimum GLIBC >= 2.28, refs https://nodejs.org/en/blog/announcements/v18-release-announce#toolchain-and-compiler-upgrades
Create meta issue for tackling DNS result order changes from Node v18, refs Unable to connect to establish a TCP connection (ECONNREFUSED) nodejs/node#40702
Options

fisforfaheem · 2023-06-05T04:47:56Z

Please consider Electron 25 it has much better performance and stability

lorand-horvath · 2023-06-09T09:10:15Z

Please consider Electron 25 it has much better performance and stability

And of course, no backward compatibility. As for stability, how can one say the first couple releases of a major version are stable? Electron 25.0.0 is barely 2 weeks old!
I said it many times before... stop asking for bleeding edge software, there are and always will be many bugs in them. Do you like your VSCode having all kinds of weird issues? I don't.
I think even Electron 24 is too early to jump on - it was first released in April.

Edit: downvote away, be my guest :-)

fisforfaheem · 2023-06-09T21:41:03Z

but using an ond chromium engine feels not safe... Also Vscode needs to focus on improving performance. [image: Mailtrack] <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&> Sender notified by Mailtrack <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&> 06/10/23, 02:39:59 AM

…

On Fri, Jun 9, 2023 at 2:10 PM Lorand Horvath ***@***.***> wrote: Please consider Electron 25 it has much better performance and stability And of course, no backward compatibility. As for stability, how can one say the first couple releases of a major version are stable? Electron 25.0.0 is barely 2 weeks old! I said it many times before... stop asking for bleeding edge software, there are and always will be many bugs in them. Do you like your VSCode having all kinds of weird issues? I don't. — Reply to this email directly, view it on GitHub <#184021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRXJSEVHWCQVYFSHLP6FUDXKLSAJANCNFSM6AAAAAAYWPFLUU> . You are receiving this because you commented.Message ID: ***@***.***>

zm-cttae · 2023-06-10T09:22:47Z

Native node fetch! Very keen on this upgrade. It'll make a lot of my WASM-related code mutch quicker.

PS: I plan to turn my wasm into a data uri and stream it using fetch in 9 months time. To give that VS Code verison time to percolate :)

tjx666 · 2023-06-12T22:22:12Z

@lorand-horvath there are two months to test and fix

fisforfaheem · 2023-06-13T06:19:33Z

Hope we see latest chromium soon! VSCODE insiders atleast should have latest version, given it's name [image: Mailtrack] <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&> Sender notified by Mailtrack <https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality11&> 06/13/23, 11:18:34 AM

…

On Tue, Jun 13, 2023 at 3:22 AM 余腾靖 ***@***.***> wrote: @lorand-horvath <https://github.com/lorand-horvath> there are two months to test and fix — Reply to this email directly, view it on GitHub <#184021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRXJSCBMGYFMINSVFY3XDDXK6JCDANCNFSM6AAAAAAYWPFLUU> . You are receiving this because you commented.Message ID: ***@***.***>

tjx666 · 2023-07-10T08:49:27Z

@deepak1556 will be released in July interation?

fisforfaheem · 2023-07-10T08:53:01Z

I agree that using blazing edge electron may get issues. But at least VSCode Insiders should have Electron version 23 or 24 to benefit. I'm not talking about the stable version of VSCode, but the Insider version.

…

On Mon, Jul 10, 2023, 1:49 PM 余腾靖 ***@***.***> wrote: @deepak1556 <https://github.com/deepak1556> will be released in July interation? — Reply to this email directly, view it on GitHub <#184021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRXJSGZMUMRLDHXY2AFOL3XPO62LANCNFSM6AAAAAAYWPFLUU> . You are receiving this because you commented.Message ID: ***@***.***>

lorand-horvath · 2023-07-10T08:58:30Z

I agree that using blazing edge electron may get issues. But at least VSCode Insiders should have Electron version 23 or 24 to benefit. I'm not talking about the stable version of VSCode, but the Insider version.

@fisforfaheem That's not how it works; this is the 3rd time you are asking to have Electron 24 only in Insiders.
Insiders is max 1 month ahead of official VSCode, you can verify that yourself. It's basically the beta testing phase.
There's also VSCode Exploration, which is the alpha development phase.

fisforfaheem · 2023-07-10T09:00:11Z

Ok, thanks for the clarification. Any idea how to find that exploration builds easily

…

On Mon, Jul 10, 2023, 1:58 PM Lorand Horvath ***@***.***> wrote: I agree that using blazing edge electron may get issues. But at least VSCode Insiders should have Electron version 23 or 24 to benefit. I'm not talking about the stable version of VSCode, but the Insider version. @fisforfaheem <https://github.com/fisforfaheem> That's not how it works; this is the 3rd time you are asking to have Electron 24 only in Insiders. Insiders is max 1 month ahead of official VSCode, you can verify that yourself. It's basically the beta testing phase. There's also VSCode Exploration, which is the alpha development phase. — Reply to this email directly, view it on GitHub <#184021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRXJSHX7H5ZBDAS55F6FQTXPO74PANCNFSM6AAAAAAYWPFLUU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

lorand-horvath · 2023-07-10T09:04:10Z

@fisforfaheem You can find VSCode Exploration version 1.75 here:
#166265 (comment)
Install it (it has the orange logo, you'll see), then start and Check for Updates which will get you the latest version 1.81-exploration (alpha).

deepak1556 · 2023-07-11T03:56:24Z

@tjx666 not likely, this iteration will be focused on resolving the two Node.js blockers

Get server executables based on Node v18 to be GLIBC >= 2.17 compatible
Adopt DNS result order changes

NCLnclNCL · 2023-08-03T00:51:49Z

https://az764295.vo.msecnd.net/exploration/a7703202794cf4894003d6502eb196192e8e0333/VSCode-win32-ia32-1.81.0-exploration.zip

thanks

zhouxinghong · 2023-08-03T07:40:17Z

It works very well! Thank you very much!

zhouxinghong · 2023-08-05T14:10:14Z

https://github.com/electron/electron/releases/tag/v25.4.0

zhouxinghong · 2023-08-14T04:39:02Z

https://github.com/electron/electron/releases/tag/v25.5.0

zhouxinghong · 2023-08-16T00:57:31Z

https://github.com/electron/electron/releases/tag/v26.0.0
Fixes a lot of bugs included Electron 25 version

tjx666 · 2023-08-29T07:08:46Z

@deepak1556 any performance improved after upgrade electron v25? I think node18 maybe improve some

fisforfaheem · 2023-08-30T13:50:01Z

yes feeling a slight performance improvement

…

On Tue, Aug 29, 2023 at 12:09 PM 余腾靖 ***@***.***> wrote: @deepak1556 <https://github.com/deepak1556> any performance improved after upgrade electron v25? I think node18 maybe improve some — Reply to this email directly, view it on GitHub <#184021 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIRXJSDCAI5DYEENARRWKGLXXWIQ5ANCNFSM6AAAAAAYWPFLUU> . You are receiving this because you were mentioned.Message ID: ***@***.***>

zhouxinghong · 2023-08-30T19:04:52Z

https://github.com/electron/electron/releases/tag/v26.1.0
https://github.com/electron/electron/releases/tag/v25.8.0
Fixes a lot of bugs included Electron 25 version

deepak1556 · 2023-09-01T02:12:48Z

@tjx666 yes we have seen nice improvements to render process launch times across all platforms, most noticeable on windows with ~80ms drop, there are also some minor script execution time improvements ~20-30ms. However on macOS we lost some time from start till app.isReady which requires investigation. But overall the score is better than Electron 22.

shannon · 2023-09-10T18:40:22Z

Just FYI, the following bug is present in Electron 25 and therefore present in the latest release of VS Code: electron/electron#38790

I realize there are probably other bugs in Electron 25 that would be present in VS Code but I ran into this one and I had to figure out if it was VS Code or electron that was the issue.

lorand-horvath · 2023-09-14T09:36:26Z

I will now venture and say (without trying to blame anyone) that the update to Electron 25 was rushed in VSCode 1.82, as I've correctly predicted would happen #184021 (comment) - that strange bugs were going to creep in.
Here's just a couple of them, but I'm sure there are many others (lack of time to track everything going on):
#190437
electron/electron#38790

I'd really like to have an Electron 22 branch build of VSCode still available and maintained, it was much more stable, no serious issues as far as I can see. And it was also working on Windows 7 without problems. But that's too much to ask, I guess.

shannon · 2023-09-17T21:03:30Z

My comment about the bug from Electron 25 being in VS Code was not to disparage the work to do the upgrade or suggest that it should not have been done. I merely wanted to point it out in case anyone else ran into it. It is a very strange bug but not show stopping. Having said that, I think this just reiterates that the work to keep VS Code inline with Electron upgrades (including any bug fixes) is important and should be as streamlined as possible.

Other than this bug, being able to now run and test my WebGPU based code directly inside VS Code has been invaluable.

deepak1556 self-assigned this Jun 1, 2023

deepak1556 added this to the June 2023 milestone Jun 1, 2023

deepak1556 added electron Issues and items related to Electron engineering VS Code - Build / issue tracking / etc. electron-24-update labels Jun 1, 2023

deepak1556 mentioned this issue Jun 1, 2023

chore: update to Electron 24 #180466

Closed

henkery mentioned this issue Jun 1, 2023

Migrate to Node 18 coder/code-server#6230

Closed

gjsjohnmurray mentioned this issue Jun 4, 2023

Please upgrade the underlying and chromium engine as well all Electron version atleast in vscode insiders #184257

Closed

deepak1556 mentioned this issue Jun 8, 2023

node 16 is reaching EOL soon, possibly security issue. #183923

Closed

deepak1556 changed the title ~~Update to Electron 24~~ Update to Electron 24/25 Jun 8, 2023

zm-cttae mentioned this issue Jun 10, 2023

[icebox] Implement builtin streaming loader for WASM from data URI vsce-toolroom/vscode-textmate-languageservice#16

Open

2 tasks

kieferrm mentioned this issue Jun 12, 2023

Iteration Plan for June 2023 #184844

Closed

74 tasks

deepak1556 mentioned this issue Jun 15, 2023

chore: add distro info to telemetry on linux #185261

Merged

devm33 mentioned this issue Jun 19, 2023

TypeError: Failed to parse URL from ./extensions/github.copilot-nightly-1.83.50/dist/tree-sitter.wasm #180787

Closed

ak1394 mentioned this issue Jun 23, 2023

connect ECONNREFUSED 127.0.0.1:4200 42Crunch/vscode-openapi#228

Closed

deepak1556 modified the milestones: June 2023, July 2023 Jun 26, 2023

kieferrm mentioned this issue Jul 9, 2023

Iteration Plan for July 2023 #187398

Closed

54 tasks

deepak1556 added this to the August 2023 milestone Jul 25, 2023

This was referenced Jul 25, 2023

Crash when rebuilding application menu on wayland #184124

Open

Mouse cursor becomes huge in full screen mode #188820

Open

vscode closes/crashes when tiling it #188566

Closed

swarnava mentioned this issue Jul 28, 2023

chore: update builds for electron@22.3.14 #189089

Merged

deepak1556 mentioned this issue Aug 1, 2023

WSL2 Ubuntu lunar font rendering issue #189384

Closed

danepowell mentioned this issue Aug 3, 2023

future: support Node 18 eclipse-theia/theia#11220

Closed

kieferrm mentioned this issue Aug 6, 2023

Iteration Plan for August 2023 #189778

Closed

65 tasks

deepak1556 closed this as completed in #188268 Aug 7, 2023

vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Aug 7, 2023

bpasero moved this from 🏃 In Progress to ✔️ Done / Deferred in VSCode Electron Integration Aug 17, 2023

benz0li mentioned this issue Aug 28, 2023

[Feat]: Update Code to 1.82 coder/code-server#6400

Closed

bpasero removed this from VSCode Electron Integration Sep 7, 2023

lorand-horvath mentioned this issue Sep 14, 2023

Support for Win7/8? VSCodium/vscodium#1264

Closed

This comment was marked as spam.

Sign in to view

microsoft locked as off-topic and limited conversation to collaborators Sep 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update to Electron 25 #184021

Update to Electron 25 #184021

deepak1556 commented Jun 1, 2023 •

edited

Loading

Todo

fisforfaheem commented Jun 5, 2023

lorand-horvath commented Jun 9, 2023 •

edited

Loading

fisforfaheem commented Jun 9, 2023 via email

zm-cttae commented Jun 10, 2023 •

edited

Loading

tjx666 commented Jun 12, 2023

fisforfaheem commented Jun 13, 2023 via email

tjx666 commented Jul 10, 2023

fisforfaheem commented Jul 10, 2023 via email

lorand-horvath commented Jul 10, 2023

fisforfaheem commented Jul 10, 2023 via email

lorand-horvath commented Jul 10, 2023 •

edited

Loading

deepak1556 commented Jul 11, 2023

NCLnclNCL commented Aug 3, 2023

zhouxinghong commented Aug 3, 2023

zhouxinghong commented Aug 5, 2023

zhouxinghong commented Aug 14, 2023

zhouxinghong commented Aug 16, 2023 •

edited

Loading

tjx666 commented Aug 29, 2023

fisforfaheem commented Aug 30, 2023 via email

zhouxinghong commented Aug 30, 2023

deepak1556 commented Sep 1, 2023 •

edited

Loading

shannon commented Sep 10, 2023 •

edited

Loading

lorand-horvath commented Sep 14, 2023 •

edited

Loading

This comment was marked as spam.

shannon commented Sep 17, 2023

Update to Electron 25 #184021

Update to Electron 25 #184021

Comments

deepak1556 commented Jun 1, 2023 • edited Loading

Todo

fisforfaheem commented Jun 5, 2023

lorand-horvath commented Jun 9, 2023 • edited Loading

fisforfaheem commented Jun 9, 2023 via email

zm-cttae commented Jun 10, 2023 • edited Loading

tjx666 commented Jun 12, 2023

fisforfaheem commented Jun 13, 2023 via email

tjx666 commented Jul 10, 2023

fisforfaheem commented Jul 10, 2023 via email

lorand-horvath commented Jul 10, 2023

fisforfaheem commented Jul 10, 2023 via email

lorand-horvath commented Jul 10, 2023 • edited Loading

deepak1556 commented Jul 11, 2023

NCLnclNCL commented Aug 3, 2023

zhouxinghong commented Aug 3, 2023

zhouxinghong commented Aug 5, 2023

zhouxinghong commented Aug 14, 2023

zhouxinghong commented Aug 16, 2023 • edited Loading

tjx666 commented Aug 29, 2023

fisforfaheem commented Aug 30, 2023 via email

zhouxinghong commented Aug 30, 2023

deepak1556 commented Sep 1, 2023 • edited Loading

shannon commented Sep 10, 2023 • edited Loading

lorand-horvath commented Sep 14, 2023 • edited Loading

This comment was marked as spam.

shannon commented Sep 17, 2023

deepak1556 commented Jun 1, 2023 •

edited

Loading

lorand-horvath commented Jun 9, 2023 •

edited

Loading

zm-cttae commented Jun 10, 2023 •

edited

Loading

lorand-horvath commented Jul 10, 2023 •

edited

Loading

zhouxinghong commented Aug 16, 2023 •

edited

Loading

deepak1556 commented Sep 1, 2023 •

edited

Loading

shannon commented Sep 10, 2023 •

edited

Loading

lorand-horvath commented Sep 14, 2023 •

edited

Loading