Fix missing stop button after elicitation is hidden#286866
Merged
roblourens merged 4 commits intomainfrom Jan 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where the stop button disappears when an elicitation request is automatically hidden while still pending. The fix ensures that hidden elicitation requests don't contribute to the pending confirmation state, allowing the stop button to remain visible.
Changes:
- Added a check for
isHiddenstate in the elicitation pending logic to prevent hidden elicitations from blocking the stop button
connor4312
requested changes
Jan 12, 2026
src/vs/workbench/contrib/chat/common/model/chatProgressTypes/chatElicitationRequestPart.ts
Outdated
Show resolved
Hide resolved
connor4312
approved these changes
Jan 12, 2026
meganrogge
approved these changes
Jan 12, 2026
eli-w-king
pushed a commit
that referenced
this pull request
Jan 14, 2026
* Fix missing stop button after elicitation is hidden Fix #283328 * Set elicitation state to rejected when hidden * Only reject when it was pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #283328
@meganrogge When the elicitation part is automatically hidden, I guess we leave the state on Pending.
This fixes it but if I update the state, does it matter to you whether it's Rejected or Accepted or should it be another ElicitationState?edit- I'm marking the elicitation as Rejected here, that seems fine, lmk if you think we should do something different though
cc @connor4312