Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This change adjusts how terminal-input chat elicitations are handled so that the “stop” button correctly reappears after the user focuses the terminal and provides input, instead of disappearing permanently.
Changes:
- Update
_createElicitationPart’s accept and reject handlers to treat asymbolreturn value (e.g.focusTerminalSelection) as a signal to keep the elicitation in aPendingstate and visible. - Defer hiding the
ChatElicitationRequestPartand clearing_promptPartuntil after the symbol case is resolved (e.g. once terminal input is received), returningElicitationState.Pendingin that interim state. - Preserve existing behavior (hide +
Accepted/Rejected) for all non-symbol return values fromonAccept/onReject.
...s/workbench/contrib/terminalContrib/chatAgentTools/browser/tools/monitoring/outputMonitor.ts
Show resolved
Hide resolved
benvillalobos
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #283328
stop-button.mov
When clicking "Focus Terminal", the elicitation was immediately hidden and its state set to
Accepted. This causedrequestInProgressto become false and never recover, so the stop button disappeared permanently.Now, when the callback returns a Symbol (like
focusTerminalSelection, we returnElicitationState.Pendinginstead of hiding the elicitation immediately. The elicitation gets properly hidden later when the user provides input in the terminal, at which pointrequestInProgresscorrectly returns to true and the stop button reappears.cc @Tyriar