Adding three finger swipe with various options. #82528
Conversation
| @@ -319,6 +321,48 @@ export class CodeWindow extends Disposable implements ICodeWindow { | |||
| }); | |||
| } | |||
|
|
|||
|
|
|||
| private registerSwipeNavigationListener(command: any, back: 'left' | 'browser-backward', forward: 'right' | 'browser-forward', config: 'actions' | 'recent-tabs' | 'tabs' | 'grouped-tabs'): void { | |||
There was a problem hiding this comment.
I couldn't use 'swipe' | 'app-command' type union here, since the definitions from Electron didn't recognize them for some reason. Open for suggestions on how to mitigate that. Adding string didn't work either.
| this._win.removeAllListeners('app-command'); | ||
| if (config && config.workbench && config.workbench.editor) { | ||
| let swipeConfig = config.workbench.editor.swipeToNavigate; | ||
| if (swipeConfig && swipeConfig !== 'off') { |
There was a problem hiding this comment.
I am not 100% sure, but it seems the integration tests run with certain values within the config as null.
I'm guessing that workBench is null in this particular test, so calling editor on it failed here.
So with that in mind I assume the type definitions in TS are invalid, since they don't indicate that they're optionals.
I'm checking every single value here just to see what the CI is saying.
|
Thanks, but I am not accepting pull requests that leverage Electron APIs. Please see https://github.com/microsoft/vscode/wiki/How-to-Contribute#pull-requests and thanks for understanding.
|
|
@bpasero I am sorry to hear, but I kinda rely heavily on this sort of UX for my workflow, coming from Xcode it's very useful to being able to have a single window and swiping quickly through history - even between tabs and past opened files. Is there anyway we could make an exception and isolating it for macOS only somehow? |
|
@seivan I think I already mentioned our options here:
|
|
@bpasero I think it's me that edited a type in your username. It's my fault, I'm sorry. |
|
Ah easy, no worries. Maybe that happened in another case as well. |
|
@bpasero can you please provide more information? here or via email works. are these notifications for commits/comments/reviews and how are these notifications being delivered (web or email)? thanks for the heads up! |
|
@becca I only consume notifications via web, but if editing it causes it to be shown again, then it would explain why this happened. |
|
depending on the edits being made that could be what's happening. is there a specific event you're referring to here that i should 👀? |
|
I will keep an eye out if this happens again and let you know, thanks for reaching out here. |
Following options have been added:
'actions'->Swipes will navigate recent action history.'tabs'->Swipes will navigate currently opened tabs.'recent-tabs'->Swipes will navigate recent tab history.'grouped-tabs'->Swipes will navigate currently opened tabs in selected group.Fix: #4803 (again)
Based on changes from: e368b34 from @bpasero & and my own PR #23663
Also fixes the confusion on what a swipe is supposed to do.
It seems most people just want or expect it to move between tabs, while I like it to function in similar fashion as Xcode.
These added options allows user to toggle their preferred setting. But it only works with a three (3) finger Swipe, as that's what the exposed Electron API uses.
Discussions:
#40526
#25447
#25325
#25449
Edit: Made an extension out of it which is a good compromise.