-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get OSArchitecture from Platform Abstraction to check for ARM Processor #1242
Get OSArchitecture from Platform Abstraction to check for ARM Processor #1242
Conversation
return Path.Combine(this.GetCurrentProcessLocation(), this.GetCurrentProcessArchitecture().ToString(), ARM); | ||
} | ||
|
||
return Path.Combine(this.GetCurrentProcessLocation(), this.GetCurrentProcessArchitecture().ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Case insensitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path is case insensitive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not on xplat.
…or (microsoft#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
* Object Model Api fix (#1231) * Adding the missing property LocalExtensionData in TestCase * Fixed the test. * Do not crash data collector if a extension initialize fails. (#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario. * Fix for changes in XPathNavigator for netcoreapp2.0 (#1226) * Fix for changes in XPathNavigator in netcoreapp2.0 * Removed IXPathNavigable. * Use TPv2 as default for .NET 3.5. (#1232) * Loading native dll's correctly for UWP release mode (#1234) * Loading native dll's correctly for UWP release mode * nit's * decouple process bitness with OS Architecture * HardCoded version of CLI to 2.1.0-preview1-007372 (#1238) HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues. Reverted to old version of CLI because of dotnet/cli#7921 * Added null check for parent node. * Added conditional statements to support building against netcoreapp1.0 * Get OSArchitecture from Platform Abstraction to check for ARM Processor (#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
…or (microsoft#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
* Object Model Api fix (#1231) * Adding the missing property LocalExtensionData in TestCase * Fixed the test. * Do not crash data collector if a extension initialize fails. (#1230) * Do not crash data collector if a extension initialize fails. * Add unit tests for the scenario. * Use TPv2 as default for .NET 3.5. (#1232) * Loading native dll's correctly for UWP release mode (#1234) * Loading native dll's correctly for UWP release mode * nit's * decouple process bitness with OS Architecture * HardCoded version of CLI to 2.1.0-preview1-007372 (#1238) HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues. Reverted to old version of CLI because of dotnet/cli#7921 * Get OSArchitecture from Platform Abstraction to check for ARM Processor (#1242) * GetOsArchitecture from Platform Abstraction to check for ARM * making sure path is always small
No description provided.