Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insertion 20171031 #1250

Merged
merged 6 commits into from
Oct 31, 2017
Merged

Insertion 20171031 #1250

merged 6 commits into from
Oct 31, 2017

Conversation

smadala
Copy link
Contributor

@smadala smadala commented Oct 31, 2017

Ported PRs:
#1231 Add back LocalExtensionData API for adapters (fix regression reported by Debugger team)
#1230 Do not crash data collector if extension fails to initialize or set environment variables (allow test runs with coverage in non Enterprise SKU)
#1232 Use TPv2 as default for .NET 3.5 test projects
#1234 Loading native dll's correctly for UWP release mode.
#1238 HardCoded version of CLI to 2.1.0-preview1-007372.

singhsarab and others added 6 commits October 31, 2017 10:29
* Adding the missing property LocalExtensionData in TestCase

* Fixed the test.
…ft#1230)

* Do not crash data collector if a extension initialize fails.

* Add unit tests for the scenario.
* Loading native dll's correctly for UWP release mode

* nit's

* decouple process bitness with OS Architecture
HardCoded version of CLI to 2.1.0-preview1-007372 as the latest version has some issues.

Reverted to old version of CLI because of dotnet/cli#7921
…or (microsoft#1242)

* GetOsArchitecture from Platform Abstraction to check for ARM

* making sure path is always small
Copy link
Contributor

@mayankbansal018 mayankbansal018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes for loading native dll's were merged yesterday, I don't understand why are they showing up again.

@smadala
Copy link
Contributor Author

smadala commented Oct 31, 2017

@mayankbansal018 We had to revert those changes #1249, This PR has all fixes of yesterday PR except Xml document update fix.

@smadala smadala merged commit 71cbcd0 into microsoft:rel/15.5 Oct 31, 2017
@smadala smadala deleted the insertion-20171031 branch October 31, 2017 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants