-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update nuspec project target frameworks for source-build #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch removes prebuilts caused from targetting netcoreapp1.0 Backported with microsoft#3188
Haplois
force-pushed
the
apply-source-build-patch
branch
from
January 31, 2022 23:22
4929b0c
to
dd1928a
Compare
@lbussell, I basically included the patch in the repository - it was unnecessary. |
Haplois
force-pushed
the
apply-source-build-patch
branch
from
February 1, 2022 00:37
9988689
to
25cce3b
Compare
Haplois
force-pushed
the
apply-source-build-patch
branch
from
February 1, 2022 01:02
7d60db3
to
61d250e
Compare
Haplois
force-pushed
the
apply-source-build-patch
branch
from
February 1, 2022 01:07
61d250e
to
8ab6499
Compare
I have verified that the current set of changes work in the end-to-end source build and that no new prebuilts are introduced. |
Haplois
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm taking over #3188 from @MichaelSimons. I'm opening this as a draft PR to get CI running.
Description
This change should remove prebuilts caused from targeting netcoreapp1.0.
Related issue
dotnet/source-build#2708