Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Backport source-build patches to repos. #2708

Closed
MichaelSimons opened this issue Jan 5, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4404
Closed

[main] Backport source-build patches to repos. #2708

MichaelSimons opened this issue Jan 5, 2022 · 1 comment · Fixed by NuGet/NuGet.Client#4404
Assignees
@crummel @MichaelSimons @lbussell
Labels
area-patch-removal Removing patches for contributing repos from source-build

Comments

@MichaelSimons
Copy link
Member

MichaelSimons commented Jan 5, 2022 •
edited
Loading

Power BI Report (Microsoft internal link)

Repo File Status PR Owner
arcade 0005-Build-Microsoft.DotNet.Build.Tasks.Workloads-for-net.patch ✔️ dotnet/arcade#8338
6.0 backport: dotnet/arcade#8384		 @lbussell
arcade 0005-Patch-sdk.props-to-target-net6.0.patch ✔️ dotnet/arcade#8338
6.0 backport: dotnet/arcade#8384		 @lbussell
arcade 0008-Bootstrapping-workaround.patch ✔️ dotnet/installer#13092 @MichaelSimons
arcade 0009-Disable-Workloads-WiX-dependency-in-source-build.patch ✔️ dotnet/arcade#8335
6.0 backport: dotnet/arcade#8384		 @lbussell
aspnetcore 0004-Revert-sourcelink-submodule-workaround.patch Reverted after breaking internal builds dotnet/aspnetcore#39324 @crummel
clicommandlineparser 0001-Remove-installation-of-runtime-2.1.0-from-build.sh.patch Won't backport - clicommandlineparser being removed from SB in 7.0
msbuild 0003-Restore-building-all-TFMs-for-source-build.patch ✔️ dotnet/msbuild#7289 @crummel
msbuild 0004-Remove-dependency-on-MS.VS.Setup.Configuration.Inter.patch ✔️ dotnet/msbuild#7289 @crummel
nuget-client 0001-Remove-uneeded-source-build-patches-and-re-patch.patch PR Merged NuGet/NuGet.Client#4404 @crummel
nuget-client 0010-Re-enable-fullfx-TFM-in-NuGet.patch PR Merged NuGet/NuGet.Client#4404 @crummel
nuget-client 0011-Update-System.Threading.Tasks.DataFlow-version.patch PR Merged NuGet/NuGet.Client#4404 @crummel
roslyn 0001-lift-version-of-Microsoft.CodeAnalysis.Common-depend.patch Issues encountered investigating @lbussell
roslyn 0003-remove-Microsoft.DotNet-prebuilts.patch PR Merged dotnet/roslyn#58727 @lbussell
roslyn 0004-Disable-apphost-build-of-csi-vbi-for-source-build.patch PR Merged dotnet/roslyn#58727 @lbussell
roslyn 0005-Build-a-subset-of-roslyn-projects.patch PR Merged dotnet/installer#13093 @lbussell
roslyn-analyzers 0001-Eliminate-pre-built-assets-during-source-build-for-r.patch Won't backport - requires repo PVP
runtime 0003-Disable-package-validation-in-source-build-for-relia.patch ✔️ dotnet/installer#13000 @lbussell
sdk 0001-Build-Microsoft.NET.Build.Tasks-for-netfx.patch ✔️ dotnet/sdk#23266 @MichaelSimons
vstest 0001-Update-nuspec-project-target-frameworks-for-source-b.patch PR Merged microsoft/vstest#3285 @lbussell
xdt 0001-Also-build-for-netstandard2.0-to-support-NuGet.patch PR Merged dotnet/xdt#445 @lbussell

✔️ indicates patch was backported and removed from dotnet/installer.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-patch-removal Removing patches for contributing repos from source-build untriaged labels Jan 5, 2022
This was referenced Jan 5, 2022
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 7, 2022
Merged
Closed
Merged
Merged
Merged
@MichaelSimons MichaelSimons mentioned this issue Jan 20, 2022
Merged
@crummel crummel mentioned this issue Jan 24, 2022
Merged
8 tasks
This was referenced Jan 24, 2022
Merged
Merged
dominoFire pushed a commit to NuGet/NuGet.Client that referenced this issue Mar 15, 2022
@crummel
Apply source-build patches (#4404)
b5f0bb7 
Fixes dotnet/source-build#2708

- Applies source-build patches to NuGet.Client repo.
- Removes IsBuildOnlyXPLATProjects property
@MichaelSimons MichaelSimons mentioned this issue Apr 18, 2022
Merged
@MichaelSimons MichaelSimons moved this from WIP to 7.0 On Deck in .NET Source Build Apr 20, 2022
@MichaelSimons MichaelSimons moved this from 7.0 On Deck to 7.0 Backlog in .NET Source Build Jul 5, 2022
@MichaelSimons
Copy link
Member Author

This issue has served it's purpose on backporting the patches that existing at 6.0 RTM.

Repository owner moved this from 7.0 Backlog to Done in .NET Source Build Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crummel crummel

@MichaelSimons MichaelSimons

@lbussell lbussell

Labels
area-patch-removal Removing patches for contributing repos from source-build
Projects
.NET Source Build
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Apply source-build patches crummel/nuget_NuGet.Client
3 participants
@crummel @MichaelSimons @lbussell