[release/6.0] Apply source build patches (backport) #8384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lbussell
commented
Jan 24, 2022
•
lbussell
commented
- Backport of Apply source build patches #8338
- part of [main] Backport source-build patches to repos. source-build#2708
This removes the prebuilt WiX dependency: dotnet#8014 The patch is temporary, pending upstream fix and dependency flow.
riarenas
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
Don't have a lot of context, but since they are ports this seems fine?
Should still get approval from @mmitche or @markwilkie before merging into the release branches.
joeloff
approved these changes
Feb 10, 2022
|
@lbussell What release does this need to go in? |
Whatever is convenient. The primary goal is to backport the patch and get it in as soon as possible in whatever release. Carrying patches equates to overhead so we would like to eliminate this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.