-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip sources when runtime provider is not found #3760
Conversation
@shyamnamboodiripad we are changing the partial discovery api to keep it extensible and to indicate sources that were knowingly skipped. We plan to later add aditional fields to the DiscoveredSource object, so we can tell TE why that particular source failed / skipped. This needs us to coordinate insertion into TE, because we are changing api that is published, but not released yet. I will prepare the change for TE tomorrow. |
src/Microsoft.TestPlatform.Common/Interfaces/Engine/ClientProtocol/DiscoveryStatus.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/ParallelProxyDiscoveryManager.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Client/Parallel/ParallelProxyExecutionManager.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Events/DiscoveredSource.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Events/DiscoveryCompleteEventArgs.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/IWarningLogger.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/IWarningLogger.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Interfaces/IWarningLogger.cs
Show resolved
Hide resolved
src/Microsoft.TestPlatform.ObjectModel/Client/Events/DiscoveredSource.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/DiscoveredSourceHelper.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.TestPlatform.CrossPlatEngine/Utilities/DiscoveredSourceHelper.cs
Outdated
Show resolved
Hide resolved
...oft.TestPlatform.AcceptanceTests/TranslationLayerTests/EventHandler/DiscoveryEventHandler.cs
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
We don't unify to a single framework anymore, so frameworks like .NET Portable don't get unified to .NET Framework anymore. So we need to rather skip unknown runtime providers than fail, because before multi-tfm it just unified to .NET Framework and passed, or unified to .NET "core" and failed.
This could be fixed by simply changing the inferred framework, but instead it is better to have a way to explicitly skip a source, instead of running it on testhost that is hopefully compatible and does nothing, or in the future also have an option to explicitly fail if we ever introduce a strict mode.
Fix #3737