Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip sources when runtime provider is not found #3760

Merged
merged 14 commits into from
Jun 15, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jun 14, 2022

We don't unify to a single framework anymore, so frameworks like .NET Portable don't get unified to .NET Framework anymore. So we need to rather skip unknown runtime providers than fail, because before multi-tfm it just unified to .NET Framework and passed, or unified to .NET "core" and failed.

This could be fixed by simply changing the inferred framework, but instead it is better to have a way to explicitly skip a source, instead of running it on testhost that is hopefully compatible and does nothing, or in the future also have an option to explicitly fail if we ever introduce a strict mode.

Fix #3737

@nohwnd nohwnd changed the title Fix provider lookup Skip sources when runtime provider is not found Jun 14, 2022
@nohwnd
Copy link
Member Author

nohwnd commented Jun 14, 2022

This is what happens when we force a framework to be net472:

image

This is what happens if we don't force a framework:
image

Before the change the second scenario would fail, because it could not find runtime provider for .NET Portable. This was a breaking change from non-multitfm.

@nohwnd
Copy link
Member Author

nohwnd commented Jun 14, 2022

@shyamnamboodiripad we are changing the partial discovery api to keep it extensible and to indicate sources that were knowingly skipped. We plan to later add aditional fields to the DiscoveredSource object, so we can tell TE why that particular source failed / skipped.

This needs us to coordinate insertion into TE, because we are changing api that is published, but not released yet. I will prepare the change for TE tomorrow.

@nohwnd
Copy link
Member Author

nohwnd commented Jun 15, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nohwnd nohwnd merged commit b5cbf14 into microsoft:main Jun 15, 2022
@nohwnd nohwnd deleted the fix-provider-lookup branch June 15, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

17.3.0-preview-20220530-08 - Can not run test in Azure Pipeline
3 participants