Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Newtonsoft to v13.0.1 #627

Merged
merged 11 commits into from
Jul 25, 2022
Merged

Upgrade Newtonsoft to v13.0.1 #627

merged 11 commits into from
Jul 25, 2022

Conversation

marmegh
Copy link
Collaborator

@marmegh marmegh commented Jul 20, 2022

Changes

Updating SARIF sdk submodule and Microsoft.NET.Test.Sdk from v17.0.0 to v17.4.0-preview-20220707-01. Address Advisory: Improper Handling of Exceptional Conditions in Newtonsoft.Json for direct Newtonsoft.Json dependencies.

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • ReleaseHistory.md updated for non-trivial changes
Release notes

Sourced from Microsoft.NET.Test.Sdk`'s releases.

17.4.0-preview-20220707-01

Issue Fixed

    • Revert #3715 #3843
    • Enable more rules on test projects #3832
    • Ignore CancelTestDiscovery test as it is flaky #3839
    • Fix Newtonsoft.Json.dll 13.0.1 signature verification #3835
    • Bump to 17.4.0 #3831
    • Upgrade to Newtonsoft.Json 13.0.1 #3815
    • Enable CA1824 - Mark assemblies with NeutralResourcesLanguageAttribute #3833
    • Make test functions static when possible #3830
    • Fix unused using warning #3828
    • Remove unused msdia140typelib_clr0200.dll #3822
    • Enable nullables on all public API files #3808
    • Fix missing signature #3796
    • Version bumped to 17.4 #3818
    • Add runtime location to host log #3806
    • Fix reading/setting culture env variables #3802
    • Enable nullable on missed files #3801
    • Enable nullable on ObjectModel #3793
    • Add missing nullable #3795
    • Improve how to retrieve process ID #3794
    • Enable nullables on common #3790
    • Fix race condition issues on stream access on LengthPrefixCommunicati??? #3789
    • Enable nullables on CrossPlatEngine #3779
    • Enable nullable on VS Translation layer #3781
    • Enable missed nullables on already handled projects #3773
    • Add background option for testhosts #3772
    • Pass sources, to fix native debug #3777
    • Temporary disable ngen for arm64 binaries #3765
    • Add default platform option to runsettings #3770
    • Support arm64 native CppUnitTestFramework with dotnet test #3768
    • Reduce usage of bang + reduce usage of throw/catch #3771
    • Fix warnings and failed assertions #3767
    • Enable nullable on Communication utilities #3758
    • Add default VS settings to playground #3756
    • Skip sources when runtime provider is not found #3760
    • Fix loop on TPDebug.Assert #3764
    • Remove backup project that should not have been checked in #3763
    • Enable nullables on acceptance tests #3757
    • Enable nullables on TRX logger #3754
    • Enable nullables on CoreUtilities #3751
    • Fix failing assertions on tests #3761
    • Get PlatformAbstractions from ObjectModel #3722
    • Fix nullable conflict #3753
    • Remove missed #nullable disable #3741
    • Fix which value is used in platform warning #3752
    • Experimental feature: enable negative values of MaxCpuCount to match a percentage of number of cores #3748
    • Enable nullables on SettingsMigrator #3744
    • Enable nullables on TestHostProvider #3738
    • Update MSTest and VSTest versions #3663
    • Fix DOTNET_ROOT env var for .NET 6.0+ #3715
    • Enable nullables on TestPlatform.Client #3745
    • Add env var to control host priority #3740

    See full log here

@marmegh marmegh marked this pull request as ready for review July 21, 2022 20:56
@@ -20,6 +20,7 @@

- BUG: Resolve `OutofMemoryException` and `NullReferenceException' failures resulting from a failure to honor file size scan limits set by `--file-size-in-kb` argument and updated Sarif.Sdk submodule to commit [ce8c5cb12d29aa407d0bf98f5fa2c764ec7fb65b](https://github.com/microsoft/sarif-sdk/commit/ce8c5cb12d29aa407d0bf98f5fa2c764ec7fb65b). [#621](https://github.com/microsoft/sarif-pattern-matcher/pull/621)
- BUG: Resolve SAL Modernization Plugin capture group showing incorrect region properties in SARIF. [#626](https://github.com/microsoft/sarif-pattern-matcher/pull/626)
- Bump Sarif.Sdk from 2.4.15 to [2.4.16]() by updating submodule to commit []()in response to [Advisory: Improper Handling of Exceptional Conditions in Newtonsoft.Json](https://github.com/advisories/GHSA-5crp-9r3c-p9vr). [#627](https://github.com/microsoft/sarif-pattern-matcher/pull/627)
Copy link
Collaborator

@eddynaka eddynaka Jul 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

()

Add the link, please.

@@ -20,6 +20,7 @@

- BUG: Resolve `OutofMemoryException` and `NullReferenceException' failures resulting from a failure to honor file size scan limits set by `--file-size-in-kb` argument and updated Sarif.Sdk submodule to commit [ce8c5cb12d29aa407d0bf98f5fa2c764ec7fb65b](https://github.com/microsoft/sarif-sdk/commit/ce8c5cb12d29aa407d0bf98f5fa2c764ec7fb65b). [#621](https://github.com/microsoft/sarif-pattern-matcher/pull/621)
- BUG: Resolve SAL Modernization Plugin capture group showing incorrect region properties in SARIF. [#626](https://github.com/microsoft/sarif-pattern-matcher/pull/626)
- Bump Sarif.Sdk from 2.4.15 to [2.4.16]() by updating submodule to commit []()in response to [Advisory: Improper Handling of Exceptional Conditions in Newtonsoft.Json](https://github.com/advisories/GHSA-5crp-9r3c-p9vr). [#627](https://github.com/microsoft/sarif-pattern-matcher/pull/627)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add the commit information and give a space from that and the word in.

Copy link
Collaborator

@eddynaka eddynaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@michaelcfanning michaelcfanning merged commit e966ad4 into main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants