Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Newtonsoft.Json 13.0.1 #3815

Merged
merged 14 commits into from
Jun 30, 2022
Merged

Upgrade to Newtonsoft.Json 13.0.1 #3815

merged 14 commits into from
Jun 30, 2022

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Jun 27, 2022

Upgrade to Newtonsoft.Json 13.0.1.

@nohwnd nohwnd closed this Jun 28, 2022
@nohwnd nohwnd reopened this Jun 28, 2022
@nohwnd nohwnd closed this Jun 28, 2022
@nohwnd nohwnd reopened this Jun 28, 2022
@nohwnd nohwnd mentioned this pull request Jun 28, 2022
Closed
Evangelink
Evangelink reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@Evangelink Evangelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot see coverage but I am unsure all the new ifs added are covered.

samples/Microsoft.TestPlatform.Protocol/Microsoft.TestPlatform.Protocol.csproj Show resolved Hide resolved
scripts/build.ps1 Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/JsonDataSerializer.cs Show resolved Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestObjectConverter.cs Outdated Show resolved Hide resolved
src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestObjectConverter.cs Outdated Show resolved Hide resolved
...tPlatform.CrossPlatEngine/AttachmentsProcessing/DataCollectorAttachmentProcessorAppDomain.cs Outdated Show resolved Hide resolved
src/testhost.arm64/app.config Show resolved Hide resolved
Haplois
Haplois reviewed Jun 29, 2022
View reviewed changes
scripts/build.sh Outdated
@@ -436,7 +436,7 @@ function publish_package()
done
#*************************************************************************************************************#

newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/9.0.1/lib/netstandard1.0/Newtonsoft.Json.dll
newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/13.0.1/lib/netstandard1.0/Newtonsoft.Json.dll
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're reading the version from Versions.props in build.ps1, can we do it here as well? This file has samples.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said done but I still see the version used here.

scripts/build/TestPlatform.Dependencies.props Show resolved Hide resolved
@Haplois Haplois self-requested a review June 29, 2022 12:04
@nohwnd nohwnd requested a review from MarcoRossignoli as a code owner June 29, 2022 12:31
MarcoRossignoli
MarcoRossignoli approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@MarcoRossignoli MarcoRossignoli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hoping that all that return null are not breaking something(if for some reason we're accidentally relying on some try/catch for NRE) 🤞

Evangelink
Evangelink reviewed Jun 29, 2022
View reviewed changes
scripts/build.sh Outdated
@@ -436,7 +436,7 @@ function publish_package()
done
#*************************************************************************************************************#

newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/9.0.1/lib/netstandard1.0/Newtonsoft.Json.dll
newtonsoft=$TP_PACKAGES_DIR/newtonsoft.json/13.0.1/lib/netstandard1.0/Newtonsoft.Json.dll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You said done but I still see the version used here.

src/Microsoft.TestPlatform.CommunicationUtilities/Serialization/TestObjectConverter.cs Outdated Show resolved Hide resolved
test/TestAssets/NewtonSoftDependency/NewtonSoftDependency.csproj Show resolved Hide resolved
This was referenced Jun 29, 2022
Closed
Closed
@nohwnd nohwnd merged commit 6815879 into microsoft:main Jun 30, 2022
@nohwnd nohwnd deleted the upgrade-to-newtonsoft-json-13 branch June 30, 2022 09:25
@Evangelink Evangelink mentioned this pull request Jul 1, 2022
Closed
@mawosoft mawosoft mentioned this pull request Jul 8, 2022
Closed
@Evangelink Evangelink mentioned this pull request Jul 12, 2022
Closed
This was referenced Jul 21, 2022
Merged
Merged
@Evangelink Evangelink mentioned this pull request Jul 29, 2022
Closed
@mawosoft mawosoft mentioned this pull request Aug 11, 2022
Closed
@Evangelink Evangelink mentioned this pull request Oct 25, 2022
Closed
nohwnd added a commit to nohwnd/vstest that referenced this pull request Feb 10, 2023
@nohwnd
Upgrade to Newtonsoft.Json 13.0.1 (microsoft#3815)
645e8e3
@nohwnd nohwnd mentioned this pull request Feb 10, 2023
Merged
nohwnd added a commit to nohwnd/vstest that referenced this pull request Feb 16, 2023
@nohwnd
Upgrade to Newtonsoft.Json 13.0.1 (microsoft#3815)
fccd6c6
nohwnd added a commit to nohwnd/vstest that referenced this pull request Feb 16, 2023
@nohwnd
Upgrade to Newtonsoft.Json 13.0.1 (microsoft#3815)
6a60556
microsoft-github-policy-service bot pushed a commit that referenced this pull request Feb 21, 2023
@nohwnd
[rel/17.3] Update Newtonsoft.Json to 13.0.1 (#4299)
be4be13 
* Upgrade to Newtonsoft.Json 13.0.1 (#3815)

* Update versions

* Move version to 17.3.3
nohwnd added a commit that referenced this pull request Feb 22, 2023
@nohwnd
[rel/17.0] Update Newtonsoft.Json to 13.0.1 (#4309
839f0c3 
* Fix build

* Upgrade to Newtonsoft.Json 13.0.1 (#3815)

* Upgrade arcade

* update vs image used to build

* Add 3.1.32 dotnet runtime

* Ignore acceptance test for multi targetting, we did not touch that, it relies on an edge case, and it does not depend on newtonsoft

* Bump version

* Fix version
nohwnd added a commit that referenced this pull request Feb 22, 2023
@nohwnd
[rel/17.2] Update Newtonsoft.Json to 13.0.1 (#4310
95fca0a 
* Upgrade to Newtonsoft.Json 13.0.1 (#3815)

* upgrade arcade

* Fix

* downgrade ubuntu

* Dowgrade ubuntu more

* Bump version

* Fix version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Evangelink Evangelink Evangelink approved these changes

@MarcoRossignoli MarcoRossignoli MarcoRossignoli approved these changes

@Haplois Haplois Awaiting requested review from Haplois

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nohwnd @Haplois @MarcoRossignoli @Evangelink