Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: WidelandsDevelopmentTeam.Widelands version 1.1 #107075

Conversation

superusercode
Copy link
Contributor

@superusercode superusercode commented May 17, 2023

Pull request has been created with Komac v1.6.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service
Copy link
Contributor

superusercode,

During validation one or more entries for "AppsAndFeatures" did not match what was detected during validation. Please make the appropriate changes to the manifest.

Template: msftbot/validationError/manifest/arpEntries

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 17, 2023
@stephengillie
Copy link
Collaborator

This package installs normally, but closes itself immediately after being launched, from a Windows 11 VM. The install log shows successful, but both the Start menu links and the EXEs themselves pop up a window that closes immediately.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label May 17, 2023
@superusercode
Copy link
Contributor Author

That isn't the behavior when installed outside of winget, so I'm not sure what changed between 1.0 and 1.1.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 17, 2023
@stephengillie
Copy link
Collaborator

That isn't the behavior when installed outside of winget, so I'm not sure what changed between 1.0 and 1.1.

I've just completed downloading through Edge and installing interactively, after first resetting the VM. The behavior persists. Does this package have a dependency on a software library such as .NET or Java? My VM might not have it installed.

@superusercode
Copy link
Contributor Author

superusercode commented May 17, 2023

widelands is built under gcc or clang per https://www.widelands.org/wiki/BuildingWidelands/ so it doesn't have any major dependencies I know of. It's mostly a C++ and Lua project https://github.com/widelands/widelands

@superusercode
Copy link
Contributor Author

superusercode commented May 17, 2023

widelands/widelands#3196 may be related since you mentioned an opengl issue in a PR I had opened previously?

@superusercode
Copy link
Contributor Author

In general open source games tend to support the newer versions of opengl (since they're more common on linux) and don't support directx.

@stephengillie
Copy link
Collaborator

In general open source games tend to support the newer versions of opengl (since they're more common on linux) and don't support directx.

Is there a way to enable logging? I didn't see a log file in the game folder.

@stephengillie stephengillie added the Blocking-Issue Manifest validation is blocked by a known issue. label May 18, 2023
@superusercode
Copy link
Contributor Author

@stephengillie have the specs used for the testing VMs changed within the past year? it's strange hitting pipeline errors with even the games that were already in winget

@stephengillie
Copy link
Collaborator

@stephengillie have the specs used for the testing VMs changed within the past year? it's strange hitting pipeline errors with even the games that were already in winget

The pipeline VMs are regularly updated with software updates. But the hardware is the same stock VM hardware.

A newer version of the game might utilize newer OS features and driver APIs, including possibly APIs which haven't been backported into VMs, as the vast majority of gamers want to maximize game performance by running on local bare metal - so VM drivers might languish due to lack of demand. I'll look into upgrading the audio and video devices in the Manual Validation pipeline.

@superusercode
Copy link
Contributor Author

image
installs and launches without issue on clean win11 vm

@stephengillie
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error Blocking-Issue Manifest validation is blocked by a known issue. labels Sep 8, 2023
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 8, 2023
@stephengillie
Copy link
Collaborator

Hi @superusercode,

This package installs normally, but doesn't launch. It opens a window and immediately closes. Is this expected?

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Sep 9, 2023
@superusercode
Copy link
Contributor Author

That did not happen to me on the virtualbox vm, so no. Something else may be missing here.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 11, 2023
@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Sep 11, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Sep 19, 2023
@microsoft-github-policy-service
Copy link
Contributor

Hello @superusercode,

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within 7 days of this comment.

Template: msftbot/noRecentActivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Author-Feedback This needs a response from the author. No-Recent-Activity No activity has occurred on this work item for seven days. Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants