Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]: Upgrade manual validation hardware #107639

Open
superusercode opened this issue May 21, 2023 · 11 comments
Open

[New Feature]: Upgrade manual validation hardware #107639

superusercode opened this issue May 21, 2023 · 11 comments
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Comments

@superusercode
Copy link
Contributor

superusercode commented May 21, 2023

Description of the new feature/enhancement

The absence of support for newer versions of opengl and lack of an audio driver on the manual validation VM causes launch errors that are specific to the pipeline and would not happen in the real world or even on a self set-up clean VM i.e. virtualbox (making this hard for new contributors to preemptively test for). This blocks PRs like #107110 #107333 #107211 #106964 #107075 and would have blocked developer tools like #107422 if not for the latter clearly stating it requires opengl 3.3+ - supported on GPUs in the last five years and near ubiquitous on windows 11. Open source programs and games lean on the newer side of opengl support since mesa is the default graphics package for most of their Linux users, so this may become a more common issue for some of the packages already in winget.

Proposed technical implementation details (optional)

A better gpu driver and an audio device would resolve these issues.

@superusercode superusercode added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label May 21, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage This work item needs to be triaged by a member of the core team. label May 21, 2023
@stephengillie stephengillie removed the Needs-Triage This work item needs to be triaged by a member of the core team. label May 22, 2023
@stephengillie stephengillie self-assigned this May 22, 2023
@stephengillie
Copy link
Collaborator

stephengillie commented Jun 12, 2023

The host may require some modification:

WARNING: We no longer support the RemoteFX 3D video adapter. If you are still using this adapter, you may become vulnerable to security risks. Learn more (https://go.microsoft.com/fwlink/?linkid=2131976)
Add-VMRemoteFx3dVideoAdapter: Hyper-V cannot add a RemoteFX 3D video adapter to this virtual machine. To add this adapter, the host must have at least one graphics processing unit (GPU) that supports RemoteFX and that meets the minimum requirements for DirectX.

@stephengillie
Copy link
Collaborator

Related: Request to revert Manual Validation pipeline to Windows 10, except for situations where MinimumOSVersion demands Windows 11.

@stephengillie
Copy link
Collaborator

Related: Request to revert Manual Validation pipeline to Windows 10, except for situations where MinimumOSVersion demands Windows 11.

Windows 10 pipeline VMs operational, completing this section.

@superusercode
Copy link
Contributor Author

What's the exact MinimumOSVersion of windows 11 to force the validation pipeline to use it?

@stephengillie
Copy link
Collaborator

stephengillie commented Jun 28, 2023

For the Manual Validation pipeline, I'm currently using 10.0.22000.0. I believe the Automatic Validation pipeline uses the same value.

(The Manual Validation pipeline is a ~1300 LOC PowerShell module that orchestrates minimally-modified VMs. It's currently hosted in a private repo, but I'd be happy to work to release it through a public Microsoft repository. I'm unsure of the best home for it.)

@superusercode
Copy link
Contributor Author

I think it would make sense for it to live in the Tools directory with the other powershell scripts, but if it becomes more common for issues to be filed against the validation environment then I think it would be better for it to have its own repository.

@stephengillie
Copy link
Collaborator

This sounds like a good location.

  • One complication I'll have to work around is that the PR Watcher is in one branch, while this will be in another branch. But the PR Watcher depends on the Manual Validation pipeline for full functionality, to run multiple new package examinations while validating moderator-approving packages. The PR Watcher code might be moved into the Manual Validation pipeline, and its branch abandoned. Unless there's a way of which I'm unaware, to reference one branch as a dependency of another branch.

@stephengillie
Copy link
Collaborator

@stephengillie
Copy link
Collaborator

@stephengillie
Copy link
Collaborator

For reference: Winget List installed packages:
image

@stephengillie stephengillie removed their assignment Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Validation-Pipeline Issues related to the manifest validation pipeline. Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Projects
None yet
Development

No branches or pull requests

3 participants