Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: ktsu.BuildMonitor version 1.0.0.0 #160177

Conversation

matt-edmondson
Copy link
Contributor

@matt-edmondson matt-edmondson commented Jun 27, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

Resolve #160180

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@matt-edmondson
Copy link
Contributor Author

#160180

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Jun 27, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Program Files\BuildMonitor\ktsu.BuildMonitor.exe returned exit code: -532462766

Automated error analysis suggests -532462766 may mean EXCEPTION_COMPLUS (Unhandled Exception)

(Automated response - build 886.)

@matt-edmondson
Copy link
Contributor Author

@stephengillie any idea how I could find out what this exception is? When installing via the local manifest I am able to successfully install and run the application with no exceptions.

@Dragon1573
Copy link
Contributor

Dragon1573 commented Jun 27, 2024

When installing via the local manifest I am able to successfully install and run the application with no exceptions.

It would be better testing local manifests with Tools/SandboxTest.ps1 in Windows Sandbox. Each developers may have their own development environment, and may have different packages pre-installed. Those pre-installed packages may affect the installation process of you local manifests.

Windows Sandbox is a pure, brand new VM instance each time you launch it. The start point will always be the same on all developers. Tools/SandboxTest.ps1 performs same actions on every Sandbox instance, so you might be able to find some important key.


Tip

Add Resolve #160180 on your very first comment can help link this pull request to your issue. When this pull request is merged, the issue will also automatically closed as completed.

This also easily prevent other volunteers & moderators from wasting time creating duplicate PRs.

@stephengillie
Copy link
Collaborator

@stephengillie any idea how I could find out what this exception is? When installing via the local manifest I am able to successfully install and run the application with no exceptions.

This same happens with a pair of other packages in the repo (Ryujinx.Ryujinx and Ryujinx.Ryujinx.Ava) on a regular basis. I've been manually swapping labels to allow them to pass, and would be happy to do the same here.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 28, 2024
@matt-edmondson
Copy link
Contributor Author

duplicate

I spent today trying to get this working, but it seems as this is an OpenGL application using the Silk.NET library (same as Ryujinx) I had no luck getting it to actually run in the sandbox, perhaps why its failing in the automation.

I am adding the vcredist installation to my nsis installer and I'll submit another release.

Thankyou both.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Executable-Error Changes-Requested Changes Requested New-Package labels Jun 28, 2024
@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed Changes-Requested Changes Requested New-Package labels Jun 29, 2024
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 29, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented Jul 1, 2024

Edit: I left it running over the weekend.

Manual Validation ended with:

Application: ktsu.BuildMonitor.exe
CoreCLR Version: 8.0.624.26715
.NET Version: 8.0.6
Description: The process was terminated due to an unhandled exception.
Exception Info: Silk.NET.GLFW.GlfwException: ApiUnavailable: WGL: The driver does not appear to support OpenGL
   at Silk.NET.GLFW.Glfw.<>c.<.cctor>b__143_0(ErrorCode errorCode, String description)
   at Silk.NET.GLFW.Glfw.CreateWindow(Int32 width, Int32 height, String title, Monitor* monitor, WindowHandle* share)
   at Silk.NET.Windowing.Glfw.GlfwWindow.CoreInitialize(WindowOptions opts)
   at Silk.NET.Windowing.Internals.WindowImplementationBase.CoreInitialize(ViewOptions opts)
   at Silk.NET.Windowing.Internals.ViewImplementationBase.Initialize()
   at Silk.NET.Windowing.WindowExtensions.Run(IView view)
   at ktsu.io.ImGuiApp.ImGuiApp.Start(String windowTitle, ImGuiAppWindowState initialWindowState, Action onStart, Action`1 onTick, Action onMenu, Action onWindowResized)
   at ktsu.BuildMonitor.BuildMonitor.Main() in D:\a\1\s\BuildMonitor\BuildMonitor.cs:line 34

Faulting application name: ktsu.BuildMonitor.exe, version: 1.0.0.0, time stamp: 0x664796e4 
Faulting module name: KERNELBASE.dll, version: 10.0.19041.1202, time stamp: 0xc9db1934 Exception code: 0xe0434352 Fault offset: 0x0000000000034f99 
Faulting process id: 0x273c 
Faulting application start time: 0x01dacbcd624488ae 
Faulting application path: C:\Program Files\BuildMonitor\ktsu.BuildMonitor.exe 
Faulting module path: C:\Windows\System32\KERNELBASE.dll Report Id: afc39ea1-facc-4841-b29e-0b04e724f848 
Faulting package full name:  
Faulting package-relative application ID:   

(Automated response - build 886.)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jul 1, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the No-Recent-Activity No activity has occurred on this work item for seven days. label Jul 6, 2024
@matt-edmondson
Copy link
Contributor Author

@stephengillie I'm not really sure how I should proceed with this as it seems like there isn't good enough support in windows sandbox to perform the validation. Is this the same situation all OpenGL applications are in? Do you know of any that pass validation I could compare?

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed No-Recent-Activity No activity has occurred on this work item for seven days. Needs-Author-Feedback This needs a response from the author. labels Jul 8, 2024
@stephengillie
Copy link
Collaborator

Hi @matt-edmondson,

I was moving too fast and didn't stop to read the error.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 9, 2024
@stephengillie stephengillie merged commit dabdf91 into microsoft:master Jul 9, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 9, 2024
@stephengillie
Copy link
Collaborator

Verify:
image

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Package Request]: ktsu.BuildMonitor
5 participants