Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: ScummVM.ScummVM version 2.8.1 #150328

Conversation

CoolPlayLin
Copy link
Contributor

@CoolPlayLin CoolPlayLin commented Apr 20, 2024

Pull request has been created with komac v2.2.1 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Apr 21, 2024
@AsciiWolf
Copy link
Contributor

Looks good, thanks! Not sure about the Validation-Executable-Error.

@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Program Files\ScummVM\scummvm.exe returned exit code: -1073741819

(Automated response - build 877.)

@AsciiWolf
Copy link
Contributor

That's weird. It works fine on my system.

@stephengillie
Copy link
Collaborator

In my testing VM, the GUI version doesn't quite launch, and the Console version gives a few more details before disappearing. (Had to pause the VM to catch it, which is why it's dimmed.)
image

WARNING: Could not initialize TTS audio!
WARNING: Could not open audio device: WASAPI can't find requested audio endpoint: Element not found.

WARNING: Unable to enable VSync: That operation is not supported!
WARNING: Libreto is not supported!

The first 3 are a known issue:

The 4th seems to indicate a dependency on Libretro.RetroArch, but this message displays even with that dependency present.

@AsciiWolf
Copy link
Contributor

AsciiWolf commented Apr 22, 2024

Yeah, most likely because of DX/OpenGL acceleration and other required things. Probably the same thing about the Windows Audio Session API that ScummVM uses to communicate directly with the endpoint audio device.

edit: Oops, did not notice that you already mentioned this in your comment. :-)

RetroArch is as far as I know an optional dependency (not intended for common use-cases) and should not be shipped with ScummVM.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Apr 22, 2024
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Apr 22, 2024
@stephengillie stephengillie merged commit 62dfbef into microsoft:master Apr 22, 2024
8 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Update Request]: ScummVM
4 participants