Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: F3d.F3d version 2.5.0 #172695

Conversation

jo-chemla
Copy link
Contributor

@jo-chemla jo-chemla commented Sep 10, 2024

Pull request has been created with komac v2.6.0 🚀

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels Sep 10, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Program Files\F3D\bin\f3d.exe returned exit code: -1073741819

Automated error analysis suggests -1073741819 may mean Converted to hexadecimal (C0000005) possibly Access Violation. (This is occasionally seen in PRs despite the install otherwise being successful. Should it be added as an InstallerSuccessCode or similar here?)

(Automated response - build 895.)

@stephengillie
Copy link
Collaborator

stephengillie commented Sep 11, 2024

Manual Validation ended with:

Fault bucket 1966890590570331726, type 5
Event Name: BEX64
Response: Not available
Cab Id: 0

Problem signature:
P1: f3d.exe
P2: 0.0.0.0
P3: 66831e0d
P4: StackHash_ac46
P5: 0.0.0.0
P6: 00000000
P7: PCH_17_FROM_ntdll+0x000000000009D8C4
P8: c0000005
P9: 0000000000000008
P10:

Attached files:
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER67B9.tmp.dmp
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER67E9.tmp.WERInternalMetadata.xml
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER67FA.tmp.xml
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER6802.tmp.csv
\?\C:\ProgramData\Microsoft\Windows\WER\Temp\WER6813.tmp.txt

These files may be available here:
\?\C:\ProgramData\Microsoft\Windows\WER\ReportArchive\AppCrash_f3d.exe_492951c7762b6c3f198b952a96f7fabf09bc0_60c9750a_d934bed5-7408-41e4-9338-995ad128de69

Analysis symbol:
Rechecking for solution: 0
Report Id: 1b273eac-a4d8-483d-98ae-3edbd41ac8c0
Report Status: 268435456
Hashed bucket: b1d75aec752de46b8b4bcc923300be4e
Cab Guid: 0

Faulting application name: f3d.exe, version: 0.0.0.0, time stamp: 0x66831e0d
Faulting module name: unknown, version: 0.0.0.0, time stamp: 0x00000000
Exception code: 0xc0000005
Fault offset: 0x0000000000000000
Faulting process id: 0x27a8
Faulting application start time: 0x01db0457694e0eae
Faulting application path: C:\Program Files\F3D\bin\f3d.exe
Faulting module path: unknown
Report Id: 1b273eac-a4d8-483d-98ae-3edbd41ac8c0
Faulting package full name:
Faulting package-relative application ID:

Edit: When launched, the application would open a small window, then immediately close.
image

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Sep 11, 2024
@jo-chemla
Copy link
Contributor Author

I just tested the manifest with winget install -m C:\Dev\winget-pkgs\manifests\f\F3d\F3d\2.5.0 and it did install correctly without any errors. The f3d viewer window should look like the following screenshot - and let the user import any mesh file to visualize it. Is there anything wrong with the selected installer?

image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Sep 11, 2024
@stephengillie
Copy link
Collaborator

Hi @jo-chemla,

It seems like the package might either depend on OpenGL, or maybe have a dependency on another software package. What are your thoughts?

@jo-chemla
Copy link
Contributor Author

The software indeed relies heavily on OpenGL from what I understand. Are these dependencies not installed by default via the winget installer current package manifest? In my case I had nothing more to do to get the installer run without errors - also tried uninstalling and reinstalling winget install -m C:\Dev\winget-pkgs\manifests\f\F3d\F3d\2.5.0 and it did end up in a correct installation.

Otherwise, should this dependency be added to the package manifest? Could not find such examples on the winget-pkgs repo searching for dependency or opengl.

@stephengillie
Copy link
Collaborator

@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Sep 12, 2024
@stephengillie stephengillie merged commit d6cb3de into microsoft:master Sep 12, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Sep 12, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Package Publish-Pipeline-Succeeded Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants