-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NetDocuments.ndSync version 2.5.0.3171 #136778
NetDocuments.ndSync version 2.5.0.3171 #136778
Conversation
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Manual Validation ended with:
(Automated response - build 671.) |
Hi @EmmaTheEmu, This package appears to require the user to accept a license agreement before use. Is this the case? Unfortunately, this kind of license usually requires explicit agreement, and including an installer switch to silently agree doesn't meet the requirement. |
Hello @stephengillie |
Still awaiting for your response regarding my question |
Hi @EmmaTheEmu, Sorry for the delay. During your testing, you didn't encounter an installer window such as the one in my previous comment above? Unfortunately, we've recently had to remove a number of manifests from our repo because their installer included a license accepting installer switch. Most licenses do not support this kind of implicit agreement, and as you said instead require the user to explicitly agree to the license terms. We're working to add an Agreements section, which would allow developers to coordinate this type of agreement with a package manager install. Here, a compounding issue is that the installer with the license terms also is not unattended. It appears that the Automatic Validation pipeline is mis-detecting the package as installed.
|
When using the manifest file - I didn't see the prompted window. I have tested it on my own machine and also on Windows Sandbox. Do note that I specified to use the MSI file which should support the ability to install silently. The zip file does include an .exe which I'm not sure if it supports silent installs. |
This is how my installation looks like on Sandbox: ndSync.mp4If required I can also add a video on how ndMail installs to that push request. |
Was the license agreement accepted in a past installation? A previous installer might have saved that information, to streamline future installs. Pipeline validations are performed on fresh installs of Windows. |
The video was filmed on the Sandbox feature. Apart from installing winget, copying manifest and enabling manifest installs - nothing else was done. |
I was wondering, would it be possible to provide the specifications of the system that the pop up appeared? I only tested this in a 22H2 Windows 11 Sandbox, but there is a separate x86 installer that might be tripping it up. |
Sure:
Here is a screenshot of a list of installed applications: #107639 (comment) |
Hello @EmmaTheEmu, This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any recent activity. It will be closed if no further activity occurs within 3 days of this comment. Template: msftbot/noRecentActivity |
winget validate --manifest <path>
?winget install --manifest <path>
?Note:
<path>
is the name of the directory containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow