Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nvcleaninstall 1.18 and fix 1.17 with nvcleaninstall.net source #220505

Conversation

Macleykun
Copy link
Contributor

@Macleykun Macleykun commented Jan 31, 2025

Checklist for Pull Requests

Manifests

  • [x ] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • [nope] This PR only modifies one (1) manifest
    Reason: 1.18 and 1.17 is broken. 1.18 there's no static url out yet and 1.17 should be fixed anyways with the static url.
  • [x ] Have you validated your manifest locally with winget validate --manifest <path>?
  • [x ] Have you tested your manifest locally with winget install --manifest <path>?
    ok i admit i didn't test but i only changed the url to one i really really know works and just removed 1.18 entirely.
  • [ x] Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@cfouche3005
Copy link
Contributor

cfouche3005 commented Jan 31, 2025

I think this PR can be closed:

  • Link for 1.17 still work (you should not use your browser or curl to test static link on techpowerup, they only allow user agent related to package manager to use these link. To test link you should use winget download --manifest <path>)
  • My PR fix download link for the 1.18 by using static link from techpowerup

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label Jan 31, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 31, 2025
@Macleykun
Copy link
Contributor Author

I think this PR can be closed:

  • Link for 1.17 still work (you should not use your browser or curl to test static link on techpowerup, they only allow user agent related to package manager to use these link. To test link you should use winget download --manifest <path>)
  • My PR fix download link for the 1.18 by using static link from techpowerup

aah i only read this now! so sorry about that! i'll immediatly close this PR then!

@Macleykun Macleykun closed this Jan 31, 2025
@Macleykun Macleykun deleted the fix-nvcleaninstall-1.17-and-remove-1.18 branch January 31, 2025 10:21
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jan 31, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PullRequest-Error PR is Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants