Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: AnyDeskSoftwareGmbH.AnyDesk version 7.0.0 #35148

Merged

Conversation

OfficialEsco
Copy link
Contributor

@OfficialEsco OfficialEsco commented Nov 17, 2021

  • Have you signed the Contributor License Agreement?
  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.0 schema?

Now THIS is a fun little experimental package
Wonder how wingetbot will handle manifest schema 1.1.0 and when there are 2 different versions

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed Possible-Duplicate labels Nov 17, 2021
@wingetbot
Copy link
Collaborator

Possible duplicate package entry.

Similar installer SHA256 hash found in manifest:

  • InstallerSha256: 1082577c084849c0e284f80e75a444696e80f4ebb95226da4ae5cc78837cd6c7
    • manifests\a\AnyDeskSoftwareGmbH\AnyDeskMSI\7.0.0

@ghost
Copy link

ghost commented Nov 17, 2021

Hello @wingetbot!

Because this pull request has the Validation-Completed label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Comment on lines +35 to +37
AppsAndFeaturesEntries:
- DisplayName: AnyDesk
- DisplayVersion: ad 7.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client doesn't know how to match with this data yet. It can validate that it looks correct but doesn't use it for matching, which probably means that the non-MSI variant will not upgrade with this manifest.

I'll still approve if you think that's okay.

Copy link
Contributor Author

@OfficialEsco OfficialEsco Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thats bad news, do you know of a ETA? the 1.1 and 1.2 preview client seems to be rolling out so hopefully its not 2022<

#35146 also got approved because i played with the ElevationRequirement variable, but it dosn't do anything on the 1.2 preview client yet..

Since you already approved the Deletion PR we have to do something about this PR tho, could probably use it for testing

edit: i'm just the guy playing around with the manifest schemas 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an oops on my part, I'm going to approve this.

@denelon is there a ETA on the implementation of microsoft/winget-cli#1073 yet?

Copy link
Contributor

@jedieaston jedieaston Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, where did you get the 1.2 preview client? The Microsoft Store? It's not in the GitHub releases for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's available as an update in the Microsoft Store if you're in the Dev Channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It DOES say client version 1.1 tho, so its probably a different «issue» then simply supporting the variables…

And yeah kinda silly that 1.2 is delivered via MS Store with no GitHub release

Copy link
Contributor Author

@OfficialEsco OfficialEsco Nov 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VM:

PS C:\Users\Esco> winget --info
Windows Package Manager v1.1.12986

AnyDesk MSI

PS C:\Users\Esco> winget list anydesk
Name    Id                          Version Source
---------------------------------------------------
AnyDesk AnyDeskSoftwareGmbH.AnyDesk 7.0.0   winget

AnyDesk EXE

PS C:\Users\Esco> winget list anydesk
Name    Id                          Version  Available Source
-------------------------------------------------------------
AnyDesk AnyDeskSoftwareGmbH.AnyDesk ad 7.0.0 7.0.0     winget

PS C:\Users\Esco> winget upgrade
Name             Id                              Version     Available    Source
--------------------------------------------------------------------------------
AnyDesk          AnyDeskSoftwareGmbH.AnyDesk     ad 7.0.0    7.0.0        winget

Whoho this issue is back

edit: signed into MS Store

PS C:\Users\Esco> winget --info
Windows Package Manager (Preview) v1.2.3131-preview

PS C:\Users\Esco> winget list anydesk; winget upgrade
Name    Id                          Version  Available Source
-------------------------------------------------------------
AnyDesk AnyDeskSoftwareGmbH.AnyDesk ad 7.0.0 7.0.0     winget

Name             Id                              Version  Available Source
--------------------------------------------------------------------------
AnyDesk          AnyDeskSoftwareGmbH.AnyDesk     ad 7.0.0 7.0.0     winget

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting ready to push the first dev client with 1.2 in the version. we had some hiccups with sequencing. We needed to get an update to the 1.1 client based on a couple of telemetry issues with "import" not reporting things quite right, and the UI changes to the App Installer for Windows 10.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the update long back but came to know after reading this message. 😂

@ghost ghost added Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 17, 2021
@ghost ghost added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 17, 2021
@ghost
Copy link

ghost commented Nov 17, 2021

Hello @OfficialEsco,
Validation has completed.

@ghost ghost merged commit 09a4f74 into microsoft:master Nov 17, 2021
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

1 similar comment
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@OfficialEsco OfficialEsco deleted the AnyDeskSoftwareGmbH.AnyDesk-7.0.0-97FA97D branch November 17, 2021 15:00
@denelon
Copy link
Contributor

denelon commented Nov 17, 2021

We haven't announced support for the 1.1 schema in validation yet. We're still working some kinks out in PPE. The client also doesn't have several of the features implemented. We decided to try getting the schema updated first since that's such a long lead time, and then work on the client implementation since that doesn't require nearly as much coordination across all the services. I'm behind on documentation as well :(

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. Possible-Duplicate Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants