Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: AnyDeskSoftwareGmbH.AnyDesk version 7.0.0 #35148

Merged
1 commit merged into from
Nov 17, 2021
Merged

Update: AnyDeskSoftwareGmbH.AnyDesk version 7.0.0 #35148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions manifests/a/AnyDeskSoftwareGmbH/AnyDesk/7.0.0/AnyDeskSoftwareGmbH.AnyDesk.installer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-2-0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.installer.1.1.0.schema.json

PackageIdentifier: AnyDeskSoftwareGmbH.AnyDesk
PackageVersion: 7.0.0
Platform:
- Windows.Desktop
MinimumOSVersion: 10.0.0.0
Scope: machine
InstallModes:
- interactive
- silent
- silentWithProgress
Installers:
- Architecture: x86
InstallerType: msi
InstallerUrl: https://download.anydesk.com/AnyDesk.msi
InstallerSha256: 1082577C084849C0E284F80E75A444696E80F4EBB95226DA4AE5CC78837CD6C7
ProductCode: '{62853EBF-E9DD-4AA5-B20A-5A6C3DD74FF3}'
UpgradeBehavior: uninstallPrevious
AppsAndFeaturesEntries:
- DisplayName: AnyDesk MSI
- DisplayVersion: 7.0.0
- Architecture: x86
InstallerType: exe
InstallerUrl: https://download.anydesk.com/AnyDesk.exe
InstallerSha256: C77496E2DBD3EEB440FF001FFC535A5AC9982DCADAB0FA1CBBC1EC0A9C9B7DC9
InstallerSwitches:
Silent: --silent
SilentWithProgress: --silent
Upgrade: --remove-first
Custom: --install "C:\Program Files (x86)\AnyDesk" --update-auto --create-desktop-icon --create-shortcuts
UpgradeBehavior: install
ElevationRequirement: elevationRequired
AppsAndFeaturesEntries:
- DisplayName: AnyDesk
- DisplayVersion: ad 7.0.0
Comment on lines +35 to +37
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client doesn't know how to match with this data yet. It can validate that it looks correct but doesn't use it for matching, which probably means that the non-MSI variant will not upgrade with this manifest.

I'll still approve if you think that's okay.

Copy link
Contributor Author

@OfficialEsco OfficialEsco Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well thats bad news, do you know of a ETA? the 1.1 and 1.2 preview client seems to be rolling out so hopefully its not 2022<

#35146 also got approved because i played with the ElevationRequirement variable, but it dosn't do anything on the 1.2 preview client yet..

Since you already approved the Deletion PR we have to do something about this PR tho, could probably use it for testing

edit: i'm just the guy playing around with the manifest schemas 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was an oops on my part, I'm going to approve this.

@denelon is there a ETA on the implementation of microsoft/winget-cli#1073 yet?

Copy link
Contributor

@jedieaston jedieaston Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, where did you get the 1.2 preview client? The Microsoft Store? It's not in the GitHub releases for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's available as an update in the Microsoft Store if you're in the Dev Channel.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It DOES say client version 1.1 tho, so its probably a different «issue» then simply supporting the variables…

And yeah kinda silly that 1.2 is delivered via MS Store with no GitHub release

Copy link
Contributor Author

@OfficialEsco OfficialEsco Nov 17, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VM:

PS C:\Users\Esco> winget --info
Windows Package Manager v1.1.12986

AnyDesk MSI

PS C:\Users\Esco> winget list anydesk
Name    Id                          Version Source
---------------------------------------------------
AnyDesk AnyDeskSoftwareGmbH.AnyDesk 7.0.0   winget

AnyDesk EXE

PS C:\Users\Esco> winget list anydesk
Name    Id                          Version  Available Source
-------------------------------------------------------------
AnyDesk AnyDeskSoftwareGmbH.AnyDesk ad 7.0.0 7.0.0     winget

PS C:\Users\Esco> winget upgrade
Name             Id                              Version     Available    Source
--------------------------------------------------------------------------------
AnyDesk          AnyDeskSoftwareGmbH.AnyDesk     ad 7.0.0    7.0.0        winget

Whoho this issue is back

edit: signed into MS Store

PS C:\Users\Esco> winget --info
Windows Package Manager (Preview) v1.2.3131-preview


PS C:\Users\Esco> winget list anydesk; winget upgrade
Name    Id                          Version  Available Source
-------------------------------------------------------------
AnyDesk AnyDeskSoftwareGmbH.AnyDesk ad 7.0.0 7.0.0     winget

Name             Id                              Version  Available Source
--------------------------------------------------------------------------
AnyDesk          AnyDeskSoftwareGmbH.AnyDesk     ad 7.0.0 7.0.0     winget

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting ready to push the first dev client with 1.2 in the version. we had some hiccups with sequencing. We needed to get an update to the 1.1 client based on a couple of telemetry issues with "import" not reporting things quite right, and the UI changes to the App Installer for Windows 10.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the update long back but came to know after reading this message. 😂

ManifestType: installer
ManifestVersion: 1.1.0
11 changes: 7 additions & 4 deletions ...eskSoftwareGmbH.AnyDesk.locale.en-US.yaml → ...eskSoftwareGmbH.AnyDesk.locale.en-US.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-1-5
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.0.0.schema.json
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-2-0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.defaultLocale.1.1.0.schema.json

PackageIdentifier: AnyDeskSoftwareGmbH.AnyDesk
PackageVersion: ad 7.0.0
PackageVersion: 7.0.0
PackageLocale: en-US
Publisher: AnyDesk Software GmbH
PublisherUrl: https://anydesk.com
Expand All @@ -22,5 +22,8 @@ Tags:
- remote-desktop
- remote-control
- rdp
# Agreements:
# ReleaseNotes:
# ReleaseNotesUrl:
ManifestType: defaultLocale
ManifestVersion: 1.0.0
ManifestVersion: 1.1.0
11 changes: 7 additions & 4 deletions ...eskSoftwareGmbH.AnyDesk.locale.zh-CN.yaml → ...eskSoftwareGmbH.AnyDesk.locale.zh-CN.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-1-5
# yaml-language-server: $schema=https://aka.ms/winget-manifest.locale.1.0.0.schema.json
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-2-0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.locale.1.1.0.schema.json

PackageIdentifier: AnyDeskSoftwareGmbH.AnyDesk
PackageVersion: ad 7.0.0
PackageVersion: 7.0.0
PackageLocale: zh-CN
Publisher: AnyDesk Software GmbH
PublisherUrl: https://anydesk.com
Expand All @@ -22,5 +22,8 @@ Tags:
- 远程控制
- 远程连接
- 远程桌面
# Agreements:
# ReleaseNotes:
# ReleaseNotesUrl:
ManifestType: locale
ManifestVersion: 1.0.0
ManifestVersion: 1.1.0
8 changes: 4 additions & 4 deletions ...ad 7.0.0/AnyDeskSoftwareGmbH.AnyDesk.yaml → ...sk/7.0.0/AnyDeskSoftwareGmbH.AnyDesk.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-1-5
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.0.0.schema.json
# Created with YamlCreate.ps1 v2.0.0 $debug=AUSU.7-2-0
# yaml-language-server: $schema=https://aka.ms/winget-manifest.version.1.1.0.schema.json

PackageIdentifier: AnyDeskSoftwareGmbH.AnyDesk
PackageVersion: ad 7.0.0
PackageVersion: 7.0.0
DefaultLocale: en-US
ManifestType: version
ManifestVersion: 1.0.0
ManifestVersion: 1.1.0
26 changes: 0 additions & 26 deletions manifests/a/AnyDeskSoftwareGmbH/AnyDesk/ad 7.0.0/AnyDeskSoftwareGmbH.AnyDesk.installer.yaml
View file
Open in desktop

This file was deleted.