Highlights the previously selected query #1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gracet9182
requested review from
adhiambovivian,
Shjokie,
ddyett,
ElinorW,
millicentachieng and
thewahome
as code owners
gracet9182
force-pushed
the
interns/gracet9182/38280-highlight-active-query
branch
from
50b5829
to
1aad577
Compare
thewahome
reviewed
Aug 9, 2021
Comment on lines
35
to
39
| groups: any[]; | ||
| constructor(props: ISampleQueriesProps) { | ||
| super(props); | ||
| this.resetCollapse = true; | ||
| this.groups = []; |
There was a problem hiding this comment.
The variables groups and resetCollapse can be declared and initialized at the point of declaration instead of declaring outside the constructor then initialising inside the constructor
There was a problem hiding this comment.
On taking a second look, the two variables groups and resetCollapse are not necessary, since the selectedQuery state variable is present
thewahome
reviewed
Aug 9, 2021
| if (prevProps.samples.queries !== this.props.samples.queries) { | ||
| this.groups = generateGroupsFromList(sampleQueries, 'category'); |
There was a problem hiding this comment.
Calculating it close to its point of need prevents having to track its location and state elsewhere in the page
There was a problem hiding this comment.
I removed it with 8c67a81 since your suggestion had it closer together to where it was needed
thewahome
reviewed
Aug 9, 2021
thewahome
reviewed
Aug 9, 2021
thewahome
requested changes
Aug 9, 2021
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
Co-authored-by: Charles Wahome <thewahome.cw@gmail.com>
thewahome
approved these changes
Aug 10, 2021
thewahome
added a commit
that referenced
this pull request
Aug 10, 2021
This reverts commit 47ba6c3.
thewahome
pushed a commit
that referenced
this pull request
Aug 10, 2021
thewahome
added a commit
that referenced
this pull request
Sep 1, 2021
* Feature: Highlights the previously selected query (#1006) * Task: upgrade packages flagged by dependabot (#1054) * Task: Fluent upgrade (#1056) * Fix: ProfileType persistence (#1074) * Enhancement: error hints (#1060) * Bug: Persisting request body (#1055) * Fix: Sample queries UI bugs (#1084) * Fix: Disable aria-required children rule (#1080) * Task: Fix failing profile test (#1086) * Enhancement: permissions radio buttons change (#1087) * Task: add English file transfer automation (#1075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Demo
Graph.Explorer.and.16.more.pages.-.Work.-.Microsoft.Edge.2021-08-04.22-33-08.mp4
Testing Instructions