Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Persisting request body #1055

Merged
merged 5 commits into from
Aug 30, 2021
Merged

Bug: Persisting request body #1055

merged 5 commits into from
Aug 30, 2021

Conversation

gracet9182
Copy link
Contributor

Overview

Here is a replication of the bug:

  • Fill in the request body and click "Run Query"
  • Click on a sample query
  • Click on "Run Query" and the previous request body that was inputted will show up again
  • If there is a malformed request body, it will also persist and show the malformed error when you run the next query

Demo

Here is a demo of the bug

Graph.Explorer.-.Microsoft.Graph.and.10.more.pages.-.Work.-.Microsoft.Edge.2021-08-11.09-24-37.mp4

Here is a demo of the fix

Graph.Explorer.and.10.more.pages.-.Work.-.Microsoft.Edge.2021-08-11.09-26-14.mp4

Testing Instructions

  • Fill in the request body and click "Run Query"
  • Click on a sample query
  • Click on "Run Query" and see that the previous request body doesn't show up anymore

@ElinorW ElinorW merged commit 4c4c9ff into microsoftgraph:dev Aug 30, 2021
thewahome added a commit that referenced this pull request Sep 1, 2021
@thewahome
Release: September 2021 (#1091)
d16607c 
* Feature: Highlights the previously selected query (#1006)

* Task: upgrade packages flagged by dependabot (#1054)

* Task: Fluent upgrade (#1056)

* Fix: ProfileType persistence (#1074)

* Enhancement: error hints (#1060)

* Bug: Persisting request body (#1055)

* Fix: Sample queries UI bugs (#1084)

* Fix: Disable aria-required children rule (#1080)

* Task: Fix failing profile test (#1086)

* Enhancement: permissions radio buttons change (#1087)

* Task: add English file transfer automation (#1075)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElinorW ElinorW ElinorW approved these changes

@adhiambovivian adhiambovivian Awaiting requested review from adhiambovivian

@ddyett ddyett Awaiting requested review from ddyett

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

@thewahome thewahome Awaiting requested review from thewahome

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gracet9182 @ElinorW