Task/accessibility ci #358
Conversation
…rosoft-graph-explorer-v4 into task/accessibility-ci
|
There's pending work on this PR, reopening it. |
|
@jobala @thewahome any reason this wasn't checked in? i see there was one test failure. |
|
@ddyett I moved to Python before I could finish working on this. Fixing the test failure is the pending work item. |
ok let's discuss when we can fit this one in |
| // @ts-ignore | ||
| const accessibilityScanResults = await AxeBuilder(driver) | ||
| .disableRules(['landmark-one-main', 'region']) // disabled as main landmark already exists on live site | ||
| .analyze(); |
There was a problem hiding this comment.
where can i find what's actually being analyzed?
There was a problem hiding this comment.
The rules can be found here:
https://github.com/dequelabs/axe-core/blob/master/doc/rule-descriptions.md#wcag-20-level-a--aa-rules
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
1 similar comment
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-358.centralus.azurestaticapps.net |
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783) * Fix: modify permissions tab UI (#790) * Track errors (#777) * Fix: sanitize url when fetching permissions (#794) * Fix: remove wrongly placed working (#795) * Fix: all permissions show as required (#797) * Task: autocomplete hover styling (#801) * Fix: Enable screen reader confirmation feedback (#802) * Migrate to eslint (#627) * Feature: resizable components (#766) * Fix: add onItemInvoked action (#806) * Fix: permissions consent (#807) * Task: accessibility ci (#358) * Fix: prevent resize when view expanded (#816) * Feature: additional telemetry (#813) * Fix: permissions tab UI (#815) * Fix: shrink request section (#822) Co-authored-by: jobala <japhethobalak@gmail.com> Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com> Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com> Co-authored-by: Azure Static Web Apps <opensource@microsoft.com> Co-authored-by: Elinor <ekaguongo@gmail.com> Co-authored-by: Millicent Achieng <achieng.milli@gmail.com> Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com> Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com> Co-authored-by: Vincent Biret <vibiret@microsoft.com> Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
Overview
Automates accessibility checks.
Fixes #791
Testing instructions
.envfile, create a variableREACT_APP_CHROMEDRIVER_PATHand save the path to yourchromedriver.exefile.For example (on a Windows PC) it would be :
REACT_APP_CHROMEDRIVER_PATH=C:\\SeleniumWebDrivers\\ChromeDriver\\chromedriver.exeTake note of the format.
npm installnpm run ci