Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: resizable components #766

Merged
merged 33 commits into from
Jan 20, 2021
Merged

Feature: resizable components #766

merged 33 commits into from
Jan 20, 2021

Conversation

thewahome
Copy link
Collaborator

@thewahome thewahome commented Nov 18, 2020 •
edited
Loading

Overview

Enables the resizing of the response and request components so that a user has the ability to increase the size of the views.
Increasing the size of the request component automatically increases the size of the response view

Closes #278
Fixes #630

Demo

Optional. Screenshots, curl examples, etc.

Notes

Optional. Ancillary topics, caveats, alternative strategies that didn't work out, anything else.

Testing Instructions

  • Hover over the bottom border of the request area
  • Notice the presence of the resize handles
  • Resize the component up or down.

@thewahome thewahome marked this pull request as draft November 18, 2020 12:40
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@darrelmiller
Copy link
Contributor

Hey @thewahome it is great to see this work progressing. I took a quick look at the latest deployment of this feature and I seemed to run into some issues. Here's the video https://microsoft-my.sharepoint-df.com/:v:/p/darrmi/EVSWOhI-oMtNkg4eOLExBfYB-v624hZOn-6VbPiNP0dFrA?e=NfJVnH

  • There is a lower resize point on the response window that doesn't seem to work as intended. I'm not sure if this is needed.
  • The upper resize point at the top of the notification message resizes the lower portion of the screen but does not resize the request body text box.
  • The sidebar resize seems to get stuck if you resize it too small.

@thewahome
Copy link
Collaborator Author

Thanks so much for taking a look at this 🙂... I will check out the video @darrelmiller

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@thewahome thewahome marked this pull request as ready for review December 2, 2020 05:22
@millicentachieng
Copy link
Contributor

@thewahome Could you please add a description of what this PR aims to do?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2020

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@thewahome
Copy link
Collaborator Author

it feels pretty limited in terms of how i can get the request section out of my way if I don't want it. Have we looked at something like an ability to expand/collapse the entire section?

#208 had described this use case. We can re-open this and track it as a new task

@ElinorW ElinorW self-requested a review January 20, 2021 07:30
@github-actions
Copy link
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://jolly-sand-0ac78c710-766.centralus.azurestaticapps.net

@thewahome thewahome merged commit 392b517 into dev Jan 20, 2021
@ElinorW ElinorW linked an issue Jan 26, 2021 that may be closed by this pull request
graph explorer contains an unecessary semi colon #812
Closed
thewahome added a commit that referenced this pull request Jan 30, 2021
@thewahome @jobala
@OfficeGlobal @msftgits @ElinorW @millicentachieng @sebastienlevert @ezkemboi @baywet @Kachulio1
chore(release): 4.2.0 (#820)
5207e09 
* Fix - replaces content-type header by accept to match HTTP and avoid CORS pre-flight (#783)

* Fix: modify permissions tab UI (#790)

* Track errors  (#777)

* Fix: sanitize url when fetching permissions (#794)

* Fix: remove wrongly placed working (#795)

* Fix: all permissions show as required (#797)

* Task: autocomplete hover styling (#801)

* Fix: Enable screen reader confirmation feedback (#802)

* Migrate to eslint (#627)

* Feature: resizable components (#766)

* Fix: add onItemInvoked action (#806)

* Fix: permissions consent (#807)

* Task: accessibility ci (#358)

* Fix: prevent resize when view expanded (#816)

* Feature: additional telemetry (#813)

* Fix: permissions tab UI (#815)

* Fix: shrink request section (#822)

Co-authored-by: jobala <japhethobalak@gmail.com>
Co-authored-by: OfficeGlobal <47977325+OfficeGlobal@users.noreply.github.com>
Co-authored-by: OfficeGlobal <OfficeGlobal@microsoft.com>
Co-authored-by: Azure Static Web Apps <opensource@microsoft.com>
Co-authored-by: Elinor <ekaguongo@gmail.com>
Co-authored-by: Millicent Achieng <achieng.milli@gmail.com>
Co-authored-by: Sébastien Levert <sebastienlevert@users.noreply.github.com>
Co-authored-by: Ezrqn Kemboi <ezrqnkemboi@gmail.com>
Co-authored-by: Vincent Biret <vibiret@microsoft.com>
Co-authored-by: Joseph Ngugi <jngugi88@gmail.com>
@thewahome thewahome deleted the feature/resizable-components branch February 17, 2021 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddyett ddyett ddyett left review comments

@jobala jobala jobala approved these changes

@ElinorW ElinorW ElinorW approved these changes

@millicentachieng millicentachieng Awaiting requested review from millicentachieng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@thewahome @darrelmiller @millicentachieng @ddyett @jobala @ElinorW