Fix for unicode regex in IE/firefox #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shweaver-MSFT
approved these changes
Apr 28, 2020
| try { | ||
| return char.match(new RegExp('\\p{L}', 'u')); | ||
| } catch (e) { | ||
| return char.toLowerCase() !== char.toUpperCase(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #406
PR Type
Description of the changes
Firefox and some other browsers do not implement 'u' for uncicode regex. The fix adds a fallback in those browsers.
Tested in Edge, Chrome, Firefox and IE11
PR checklist
npm run build) and changes have been tested in supported browsers (including IE11)mgt/nextfor new features]. Docs PR:Other information