Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IsComposable to false for all functions with a ReturnType of workbookRange #561

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

irvinesunday
Copy link
Contributor

@irvinesunday irvinesunday merged commit 608d28e into master Jan 23, 2024
24 checks passed
@irvinesunday irvinesunday deleted the is/composable-false-workbookRange branch January 23, 2024 10:02
@baywet
Copy link
Member

baywet commented Jan 23, 2024

@andrueastman @irvinesunday joining the party late here. I just wanted to make sure this change is not going to result in us pulling existing APIs away from the generated SDKs?

@andrueastman
Copy link
Member

andrueastman commented Jan 23, 2024

@baywet As the conversion library(Hidi) did not support the composable functions paths until now, the paths dropped by this change on functions returning workbookRange had not been published before(generation would not succeed as reported at microsoftgraph/MSGraph-SDK-Code-Generator#1141). So, the result for SDKs should be more paths exposed without the paths that would have been added for workbookRange. Hopefully this makes sense.

@baywet
Copy link
Member

baywet commented Jan 23, 2024

yep, thanks for the additional context, that's all I needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants