Errors on certain route transitions

[galfert]

I noticed that ember-perf throws errors on certain route transitions.

The first one is thrown when transitioning between routes with the same name but different params (e.g. from /articles/1 to /articles/2). The error is:

Cannot set property 'endTime' of undefined TypeError: Cannot set property 'endTime' of undefined at TransitionData.routeFinishedSetup

which is thrown in

ember-perf/addon/core/transition-data.js

Line 43 in 5715a2d

r.endTime = endTime;

I think the reason for this is that activateRoute from

ember-perf/addon/core/transition-data.js

Line 26 in 5715a2d

prototype.activateRoute = function activateRoute(route) {

is never called on this transition, and thus this.routes stays empty.

The second error happens when transitioning between routes with the same name, but different query params (e.g. from /bookmarks?category=news to /bookmarks?category=politics).
The error is

Assertion Failed: Must have at least a route name

which is thrown in

ember-perf/addon/services/ember-perf.js

Line 68 in 5715a2d

assert('Must have at least a route name', transitionRoute);

.

I created a basic Ember app at https://github.com/galfert/ember-perf-bugs that reproduces these two errors.

[galfert]

I was able to prevent the first error by changing this.get('perfService').routeActivated(this); to get called from setupController() instead of activate() in

ember-perf/addon/ext/route.js

Line 6 in 5715a2d

activate() {

.

I think setupController is the next in line of route hooks after activate, but it gets called every time. Not sure this change has any other implications though.

It also doesn't prevent the second error from happening.