Fix routing bug transitioning between two routes with differen params #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> The first one is thrown when transitioning between routes with the same name but different params (e.g. from /articles/1 to /articles/2). The error is: mike-north#83
This fixes the bug: > The first one is thrown when transitioning between routes with the same name but different params (e.g. from /articles/1 to /articles/2). The error is: ref mike-north#83
ryanlabouve
commented
Apr 17, 2018
| assert.deepEqual(data.routes.map((r) => r.name), ['application', 'loading', 'company', 'company.loading', 'company.buildings'], 'Proper routes load'); | ||
|
|
||
|
|
||
| let rs = data.routes.map((r) => r.name) |
There was a problem hiding this comment.
I don't love having to do this, but I wasn't' sure how to maintain the same validate-event helper with introducing the second main resource path for articles (that I used to reproduce the bug).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug
Originally outlined here: #83
(This build will fail until rebased on top of #146)
First commit:
Second commit:
