test: correct execution runner for coverage report #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior refactoring to use `poetry` for dependency management, the `coverage` command was executed directly. This was changed to use `poetry run` to ensure the correct version of `coverage` was used. However, the `coverage report` command was not updated to use `poetry run` and thus was not using the correct version of `coverage`. Signed-off-by: Mike Fiedler <miketheman@gmail.com>
|
Code Climate has analyzed commit 5c06093 and detected 0 issues on this pull request. View more on Code Climate. |
👇 Click on the image for a new way to code review
Legend |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior refactoring to use
poetryfor dependency management, thecoveragecommand was executed directly. This was changed to usepoetry runto ensure the correct version ofcoveragewas used.However, the
coverage reportcommand was not updated to usepoetry runand thus was not using the correct version ofcoverage.Signed-off-by: Mike Fiedler miketheman@gmail.com