Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Typeable for inner classes #798

Merged
merged 1 commit into from
Dec 29, 2019
Merged

Conversation

joroKr21
Copy link
Collaborator

Fixes #748

@codecov-io
Copy link

codecov-io commented Dec 27, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@491890e). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #798   +/-   ##
=========================================
  Coverage          ?   87.99%           
=========================================
  Files             ?       64           
  Lines             ?     1499           
  Branches          ?        4           
=========================================
  Hits              ?     1319           
  Misses            ?      180           
  Partials          ?        0
Impacted Files Coverage Δ
core/src/main/scala/shapeless/typeable.scala 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 491890e...4e4c12c. Read the comment docs.

@milessabin
Copy link
Owner

Where do you see warnings?

@milessabin
Copy link
Owner

This LGTM ...

@joroKr21
Copy link
Collaborator Author

Thanks, had to rebase again because somehow lost the change from #861 but should be good now.

@joroKr21 joroKr21 merged commit 8626f15 into milessabin:master Dec 29, 2019
@joroKr21 joroKr21 deleted the typeable branch December 29, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typeable should check the owner of nested types
3 participants