Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Typeable macros not dependent on default Predef presence #861

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Make Typeable macros not dependent on default Predef presence #861

merged 1 commit into from
Dec 17, 2019

Conversation

MateuszKubuszok
Copy link
Contributor

Typeable macros used classOf directly - it breaks if one uses settings like -Yno-predef or similar (#860). This PR should fix it.

@codecov-io
Copy link

codecov-io commented Sep 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@75454d9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #861   +/-   ##
========================================
  Coverage          ?   87.9%           
========================================
  Files             ?      65           
  Lines             ?    1497           
  Branches          ?       5           
========================================
  Hits              ?    1316           
  Misses            ?     181           
  Partials          ?       0
Impacted Files Coverage Δ
core/src/main/scala/shapeless/typeable.scala 0% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75454d9...7a97f28. Read the comment docs.

Copy link
Collaborator

@joroKr21 joroKr21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but needs rebase 👍

More hygiene is always better.

@joroKr21 joroKr21 added the Bug label Dec 17, 2019
@joroKr21 joroKr21 added this to the shapeless-2.4.0 milestone Dec 17, 2019
Typeable macros used classOf directly - it breaks if one uses
settings like -Yno-predef or similar.
@joroKr21
Copy link
Collaborator

@MateuszKubuszok hope you don't mind I rebased the PR myself.

Thank you for the fix! 👍

@joroKr21 joroKr21 merged commit d99e3b1 into milessabin:master Dec 17, 2019
@MateuszKubuszok
Copy link
Contributor Author

No problem, thanks! I'm on vacation so I don't look at github very often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants