Add enharmonic sharp/flat toggle in pattern menu

[ebinwalter]

This addresses #98, purportedly giving parity with yet more trackers.

Questions:

• Do we want this to be a configuration setting instead of just a per-session toggle?
• Is this place in the context menu a suitable location for the feature?

[ebinwalter]

Thinking about this more, likely it should remain a toggle and not become a persistent setting---plenty of music wherein the key changes halfway through the song, and being able to swap between the two settings without applying changes to config is probably for the best.

[coderofsalvation]

Makes sense!
Btw. thanks & welcome to the wonderful world of milkytracker.

Could you shorten the 'Toggle sharp/flat display' to something shorter, so that it does not exceed the contextmenu?
Keeping it short is important because milkytracker also runs on tiny devices:

• Toggle # or b
• Toggle harmonic
• Toggle flat notes

Or even better, add the menuitem to:

pattern    >   Transpose
               Advanced edit
               Toggle sharp/flat display

That location is more appropriate for the feature imho, and you don't have to shorten it.
The 'toggle follow' is more related to the playback-engine.

[ebinwalter]

I think I'll do it under the pattern menu like you said, and 'toggle # or b' sounds like the way to go, since we don't have checkmarks for feedback to show whether the toggle is enabled or not (unless this is broken for already-implemented things on my system?).

[ebinwalter]

Well, there we go. I've also refactored the event to better fit with your advice; it's now BUTTON_PATTERN_ instead of a BUTTON_ABOUT_ event.

Thank you as well for the warm welcome!