Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the issue of replicate message exception when the ttMsgEnable config is changed dynamically #38178

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

SimFG
Copy link
Contributor

@SimFG SimFG commented Dec 3, 2024

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 3, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 3, 2024
Copy link
Contributor

mergify bot commented Dec 3, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 3, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.87%. Comparing base (efbfa1c) to head (72eb39c).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/util.go 71.42% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38178      +/-   ##
==========================================
- Coverage   80.87%   80.87%   -0.01%     
==========================================
  Files        1373     1373              
  Lines      192994   193006      +12     
==========================================
+ Hits       156093   156098       +5     
- Misses      31374    31379       +5     
- Partials     5527     5529       +2     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.91% <ø> (ø)
Go 82.98% <81.81%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/proxy.go 70.33% <100.00%> (ø)
internal/proxy/replicate_stream_manager.go 100.00% <100.00%> (ø)
pkg/mq/msgstream/mq_msgstream.go 79.88% <100.00%> (-0.81%) ⬇️
internal/rootcoord/util.go 87.12% <71.42%> (-1.82%) ⬇️

... and 17 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 6, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 6, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 6, 2024

@SimFG go-sdk check failed, comment rerun go-sdk can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 6, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 6, 2024
@sre-ci-robot sre-ci-robot added area/dependency Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 13, 2024
@mergify mergify bot removed the ci-passed label Dec 13, 2024
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 13, 2024
…nfig is changed dynamically

Signed-off-by: SimFG <bang.fu@zilliz.com>
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit fa8ac09 into milvus-io:master Dec 14, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 14, 2024
… changed dynamically (#38440)

- issue: #38177
- pr: #38178

Signed-off-by: SimFG <bang.fu@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants