Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] replicate message exception when the ttMsgEnable config is changed dynamically #38440

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 13, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.21%. Comparing base (1da4ac4) to head (e8529e7).
Report is 1 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datanode/data_sync_service.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38440      +/-   ##
==========================================
- Coverage   79.50%   72.21%   -7.30%     
==========================================
  Files        1077     1077              
  Lines      169330   169331       +1     
==========================================
- Hits       134633   122288   -12345     
- Misses      30234    42590   +12356     
+ Partials     4463     4453      -10     
Files with missing lines Coverage Δ
internal/proxy/proxy.go 70.24% <100.00%> (ø)
internal/proxy/replicate_stream_manager.go 100.00% <100.00%> (ø)
pkg/mq/msgstream/mq_msgstream.go 81.11% <100.00%> (+0.02%) ⬆️
internal/datanode/data_sync_service.go 72.38% <0.00%> (ø)

... and 259 files with indirect coverage changes

… changed dynamically

Signed-off-by: SimFG <bang.fu@zilliz.com>
Copy link
Contributor

mergify bot commented Dec 13, 2024

@SimFG E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SimFG
Copy link
Contributor Author

SimFG commented Dec 13, 2024

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 13, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4c896c6 into milvus-io:2.4 Dec 14, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants