Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinned New Version of snowflake-sqlalchemy Supporting SQLAlchemy 2 #9480

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

MinuraPunchihewa
Copy link
Contributor

Description

This PR pins the new release of snowflake-sqlalchemy that supports SQLAlchemy 2. Here is the relevant reference: snowflakedb/snowflake-sqlalchemy#380

In relation to this change, the following has also been done:

  1. A previously added tip to install Git (when using Docker) in order to support the use of the forked repository for the above package has been removed from the documentation and the README.
  2. The imports in the handler have been re-organized to prevent a circular dependency issue.

Fixes #9024

Type of change

  • 🐛 Bug fix (non-breaking change which fixes an issue)

Verification Process

To ensure the changes are working as expected:

  • Test Location: tests/unit/handlers/test_snowflake.py for unit tests and mindsdb/integrations/handlers/snowflake_handler/tests/test_snowflake_handler.py for integration tests.
  • Verification Steps: Run the above test modules (for integration tests, a Snowflake account will be required).

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@MinuraPunchihewa
Copy link
Contributor Author

@ZoranPandovski I believe this works, but I was not able to test it by actually connecting to Snowflake because it seems like the free trial that had been granted to the account that we were using has been revoked.

@ZoranPandovski ZoranPandovski merged commit 492fb7d into main Jul 10, 2024
14 checks passed
@ZoranPandovski ZoranPandovski deleted the bugfix/fix_snwflk_sqlalchemy_deps branch July 10, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Snowflake SQLAlchemy Dependency Issue
2 participants