Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinned New Version of snowflake-sqlalchemy Supporting SQLAlchemy 2 #9480

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Pinned New Version of snowflake-sqlalchemy Supporting SQLAlchemy 2 #9480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0029132
pinned the new version of snowflake-sqlalchemy
MinuraPunchihewa Jul 10, 2024
7f2b249
removed the tip to install git from docs and README
MinuraPunchihewa Jul 10, 2024
cd49936
re-arranged imports to prevent circular dep issues
MinuraPunchihewa Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions docs/integrations/data-integrations/snowflake.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,6 @@ Before proceeding, ensure the following prerequisites are met:
1. Install MindsDB locally via [Docker](/setup/self-hosted/docker) or [Docker Desktop](/setup/self-hosted/docker-desktop).
2. To connect Snowflake to MindsDB, install the required dependencies following [this instruction](/setup/self-hosted/docker#install-dependencies).

<Tip>
Please note that, if you are using Docker to run MindsDB, before installing the dependencies for this integration as per the instructions given above, it is currently necessary to install Git in the container. To do this, run the following commands:

Start an interactive shell in the container:
```bash
docker exec -it mindsdb_container sh
```
If you haven't specified a name when spinning up the MindsDB container with `docker run`, you can find it by running `docker ps`.

Install Git:
```bash
apt-get -y update
apt-get -y install git
```

The need to perform this step will be removed in future versions of MindsDB.
</Tip>

## Connection

Establish a connection to your Snowflake database from MindsDB by executing the following SQL command:
Expand Down
18 changes: 0 additions & 18 deletions mindsdb/integrations/handlers/snowflake_handler/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,24 +13,6 @@ Before proceeding, ensure the following prerequisites are met:
1. Install MindsDB locally via [Docker](/setup/self-hosted/docker) or [Docker Desktop](/setup/self-hosted/docker-desktop).
2. To connect Snowflake to MindsDB, install the required dependencies following [this instruction](/setup/self-hosted/docker#install-dependencies).

<Tip>
Please note that, if you are using Docker to run MindsDB, before installing the dependencies for this integration as per the instructions given above, it is currently necessary to install Git in the container. To do this, run the following commands:

Start an interactive shell in the container:
```bash
docker exec -it mindsdb_container sh
```
If you haven't specified a name when spinning up the MindsDB container with `docker run`, you can find it by running `docker ps`.

Install Git:
```bash
apt-get -y update
apt-get -y install git
```

The need to perform this step will be removed in future versions of MindsDB.
</Tip>

## Connection

Establish a connection to your Snowflake database from MindsDB by executing the following SQL command:
Expand Down
2 changes: 1 addition & 1 deletion mindsdb/integrations/handlers/snowflake_handler/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
snowflake-connector-python>=2.7.12
snowflake-sqlalchemy @ git+https://github.com/ea-rus/snowflake-sqlalchemy
snowflake-sqlalchemy>=1.6.1
2 changes: 1 addition & 1 deletion mindsdb/integrations/handlers/snowflake_handler/snowflake_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from pandas import DataFrame
from snowflake import connector
from snowflake.sqlalchemy import snowdialect
from snowflake import connector

from mindsdb.utilities import log
from mindsdb_sql.parser.ast.base import ASTNode
Expand Down
Loading