MinecraftDev erroneously reports that Sponge's @DefaultConfig annotation can't be applied to configurate 4 ConfigurationReference or ConfigurationLoader
#2316
Labels
Comments
nelind3
added a commit
to nelind3/MinecraftDev
that referenced
this issue
Jun 19, 2024
RedNesto
added
platform: sponge
status: accepted
nelind3
added a commit
to nelind3/MinecraftDev
that referenced
this issue
Jun 20, 2024
nelind3
added a commit
to nelind3/MinecraftDev
that referenced
this issue
Jun 20, 2024
Earthcomputer
pushed a commit
that referenced
this issue
Jul 3, 2024
* Fix #2278 1.20.5 requires Java 21 * Suppress `ReferenceToMixin` for `@Dynamic` (#2280) * Suppress `ReferenceToMixin` for `@Dynamic` * Fix formatting for `MixinClassCannotBeReferencedSuppressor` * Move logic to `MixinClassReferenceInspection` * Update NeoForge MDK Up until neoforged/MDK@6074a78 * Small adjustment to fabric's build.gradle template Following fabric-example-mod change for 1.20.5 * Version 1.7.5 * change error requirements from public to non-private (#2289) untested, I just used the web editor * Add NeoGradle version dropdown * NeoForge 1.20.5 template * Only show the 50 most recent NeoGradle versions * Allow dynamic selectors to choose the class to perform member lookups in (#2293) * * fix dynamic selector missing namespace when the selector declares it at registration * allow dynamic selectors to change the target class that is used when looking up members * move custom owner over to mixin selector * Add 2024.2 to readme * Fix typo It's late okay * New: Add support for `@WrapMethod` in MixinExtras. (#2300) * New: Support `WrongOperationParametersInspection` in `@WrapMethod`s. (#2303) * Minecraft 1.21 templates * Version 1.7.6 * fix: #2316 (#2317) * Initial support for NeoForge's ModDevGradle Mappings don't work currently, the TSRG file seems to contain indices to an array in another JSON file? * Improve fabric.mod.json entrypoints insight - Recognize entrypoints declared in object form - Add more conditions to the inspection - Add some tests to cover the inspection Fixes #2296 * MixinExtras Expressions: Migrate to Expressions library. * Fix: Resolve being unable to get the descriptor for some complex types. * MixinExtras Expressions: Recreate `ClassInfo#getCommonSuperClassOrInterface`. It's quite scuffed and often returns `Object` even when there is a suitable common interface, but what's important is that this matches the runtime logic. --------- Co-authored-by: RedNesto <RedNestoMC@gmail.com> Co-authored-by: senseiwells <66843746+senseiwells@users.noreply.github.com> Co-authored-by: 7410 <85879080+O7410@users.noreply.github.com> Co-authored-by: Bawnorton <bawnorton@me.com> Co-authored-by: Nel <57587152+nelind3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Minecraft Development for IntelliJ plugin version
2024.1-1.7.6
IntelliJ version
IC-241.17890.1
Operating System
Fedora Linux
Target platform
Sponge
Description of the bug
While the Configurate 4 paths for
ConfigurationReferenceandConfigurationLoaderhave been added toSpongeInjectionInspectionthecheckConfigfunction still only checks for pre Configurate 4 classes and as such erroneously reports that the annotation can't be applied to the Configurate 4 versions of the interfaces.The text was updated successfully, but these errors were encountered: