Allow dynamic selectors to choose the class to perform member lookups in #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t at registration * allow dynamic selectors to change the target class that is used when looking up members
Earthcomputer
approved these changes
May 9, 2024
Earthcomputer
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Fix #2278 1.20.5 requires Java 21 * Suppress `ReferenceToMixin` for `@Dynamic` (#2280) * Suppress `ReferenceToMixin` for `@Dynamic` * Fix formatting for `MixinClassCannotBeReferencedSuppressor` * Move logic to `MixinClassReferenceInspection` * Update NeoForge MDK Up until neoforged/MDK@6074a78 * Small adjustment to fabric's build.gradle template Following fabric-example-mod change for 1.20.5 * Version 1.7.5 * change error requirements from public to non-private (#2289) untested, I just used the web editor * Add NeoGradle version dropdown * NeoForge 1.20.5 template * Only show the 50 most recent NeoGradle versions * Allow dynamic selectors to choose the class to perform member lookups in (#2293) * * fix dynamic selector missing namespace when the selector declares it at registration * allow dynamic selectors to change the target class that is used when looking up members * move custom owner over to mixin selector * Add 2024.2 to readme * Fix typo It's late okay * New: Add support for `@WrapMethod` in MixinExtras. (#2300) * New: Support `WrongOperationParametersInspection` in `@WrapMethod`s. (#2303) * Minecraft 1.21 templates * Version 1.7.6 * fix: #2316 (#2317) * Initial support for NeoForge's ModDevGradle Mappings don't work currently, the TSRG file seems to contain indices to an array in another JSON file? * Improve fabric.mod.json entrypoints insight - Recognize entrypoints declared in object form - Add more conditions to the inspection - Add some tests to cover the inspection Fixes #2296 * MixinExtras Expressions: Migrate to Expressions library. * Fix: Resolve being unable to get the descriptor for some complex types. * MixinExtras Expressions: Recreate `ClassInfo#getCommonSuperClassOrInterface`. It's quite scuffed and often returns `Object` even when there is a suitable common interface, but what's important is that this matches the runtime logic. --------- Co-authored-by: RedNesto <RedNestoMC@gmail.com> Co-authored-by: senseiwells <66843746+senseiwells@users.noreply.github.com> Co-authored-by: 7410 <85879080+O7410@users.noreply.github.com> Co-authored-by: Bawnorton <bawnorton@me.com> Co-authored-by: Nel <57587152+nelind3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
MixinSquared's
@TargetHandleris a dynamic selector which targets merged handlers, the accepted references are the name of the mixin and the original name of the handler. The method targeting is the same as@At.methodbut the members are declared in the mixin class specified by themixinattribute, thus, when looking up members for a@TargetHandlerselector, the class specified inmixinwould be the one to lookup. Mcdev's member lookups work off the target class specified in the@Mixinannotation, thus, this change is needed to allow the lookup to occur in a different class.This pr also fixes namespace lookup as you do not have to declare the namespace for a dynamic selector in the annotation and can instead declare it at registration.
See #2287