-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed When the MINIO_BROWSER_REDIRECT_URL parameter contains path, the console cannot be accessed normally. #2725
Conversation
@dvaldivia @bexsoft hello brother, I have been running the code associated with the PR locally and promoted it within our team for a while. Please review whether the code can be merged into your branch. |
Reverse proxying the console to a subpath of the same domain where the minio server is running is much needed, +1 for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sending this change, I've added some comments to it.
Issue #2774 has been assigned and will be addressed there. |
the way we regenerate the auto-generated files from the swagger specification is via the |
I'm not able to test this PR successfully, do you mind sharing your mine is simply
but I don't see the assets successfully getting served |
Did you forget that
it works fine. |
89ec1af
to
d41ffa1
Compare
…e console cannot be accessed normally.
If you start the console through minio server instead of directly starting the console, you also need to inject basepath into minio server according to this submission. |
This should have been solved here #2818, please reopen if this is not the case. Thanks. |
What does this do?
When the MINIO_BROWSER_REDIRECT_URL parameter contains path, like http://0.0.0.0:9001/minio-console, the homepage cannot be accessed.
How does it look?
How to test this PR?
1、Run the following command in the portal-ui directory:
2、According to the PR, modify three lines of code in the
minio
.minio/minio#17259
Use the local console project in the go.mod file of the minio.
Build minio.
3、Configure the MINIO_BROWSER_REDIRECT_URL env, like MINIO_BROWSER_REDIRECT_URL=http://localhost:9001/minio-console, and then run the minio server(The example is in Windows.).
4、Access the minio console through
http://localhost:9001/minio-console/
in browser5、If Nginx is used, you need to configure /subpath/ and /subpath/ws/.
Relates to: #2774