-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Applying same console fix for the subpath issue #1616
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works with operator standalone binary - but in k8s I cant get it to respect the env parameter. It keeps navigating back to I validated from within the operator pod:
|
Add the var in the console deployment: apiVersion: apps/v1
kind: Deployment
metadata:
name: console
spec:
replicas: 1
selector:
matchLabels:
app.kubernetes.io/instance: minio-operator-console
app.kubernetes.io/name: operator
template:
metadata:
creationTimestamp: null
labels:
app.kubernetes.io/instance: minio-operator-console
app.kubernetes.io/name: operator
spec:
containers:
- name: operator
image: docker.io/minio/operator:v5.0.4-13-g041a74ca
args:
- ui
- '--certs-dir=/tmp/certs'
ports:
- name: http
containerPort: 9090
protocol: TCP
- name: https
containerPort: 9443
protocol: TCP
env:
- name: OPERATOR_SUBPATH
value: /minio-operator/ |
Hop to a tenant doesn't seem to work - when I remove the SUBPATH env variable and restart the console pod, it works again |
pjuarezd
approved these changes
Jun 12, 2023
cesnietor
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective:
To fix issue: #1607 and be able to use a sub-path for Operator UI.
Story:
This issue is very similar to minio/console#2045 and maybe same fix should apply here: minio/console#2725
Reasoning:
I think this fix is easier than console because we don't need minio binary for Operator, hence the testing is more straightforward
How to test locally:
Thank you https://github.com/polaris-phecda @polaris-phecda for the fix!.
Also tested in k8s environment: