Update Service Acct fns based on new ListServiceAccounts type

[kaankabalak]

As per minio/mc#4576, in order to be able to list Service Accounts with their expiration dates on mc, we would need to update Service Account functions in Console.

Please merge this PR before minio/minio#17249 as it is a dependency.

[kaankabalak]

Tests seem to be failing as we are not pointing to the correct branches, @kannappanr could you advise me on how we move forward in these cases? Do we temporarily add a replace directive on go.mod that points to the branch while we run the tests?

[cesnietor]

Tests seem to be failing as we are not pointing to the correct branches, @kannappanr could you advise me on how we move forward in these cases? Do we temporarily add a replace directive on go.mod that points to the branch while we run the tests?

Since this is a dependency, we would need to first upgrade mc @kaankabalak and then do a release so that we can update it here in console.

[kaankabalak]

Will address the integration test failure

[kaankabalak]

Will address the integration test failure

Fixed the restapi test, however the integration test is failing as we are using the minio/minio image that doesn't contain the change located at minio/minio#17249.

[vadmeste]

LGTM

[kaankabalak]

I have just updated the PR to use the untagged mc version which includes minio/mc#4576, we can now merge the PR if it's okay to do so 👍

[dvaldivia]

@kaankabalak I also see minio/minio#17249 is not merged yet

[harshavardhana]

@kaankabalak I also see minio/minio#17249 is not merged yet

It needs to be merged here first since this is a server dependency.

[kaankabalak]

@kaankabalak I also see minio/minio#17249 is not merged yet

Hi @dvaldivia, as @harshavardhana said, this is a dependency for minio/minio#17249, therefore we can merge this PR first 👍

I have also edited the first comment of this PR accordingly.

[harshavardhana]

A failing test due to the server not having the support for the new data structure

&{500 Internal Server Error 500 HTTP/1.1 1 1 map[Content-Length:[199] Content-Type:[application/json] Date:[Tue, 30 May 2023 17:06:01 GMT] Server:[MinIO Console] Vary:[Accept-Encoding] X-Content-Type-Options:[nosniff] X-Frame-Options:[DENY] X-Xss-Protection:[1; mode=block]] 0xc000b96120 199 [] true false map[] 0xc00120e900 <nil>} <nil>
StatusCode: 500
    users_test.go:763: 
        	Error Trace:	/home/runner/work/console/console/integration/users_test.go:763
        	Error:      	Not equal: 
        	            	expected: 200
        	            	actual  : 500
        	Test:       	TestCreateServiceAccountForUser
        	Messages:   	Http Response: {"code":500,"detailedMessage":"json: cannot unmarshal string into Go struct field ListServiceAccountsResp.accounts of type madmin.ServiceAccountInfo","message":"an error occurred, please try again"}
    users_test.go:769: 
        	Error Trace:	/home/runner/work/console/console/integration/users_test.go:769
        	Error:      	Not equal: 
        	            	expected: 214
        	            	actual  : 40
        	Test:       	TestCreateServiceAccountForUser
        	Messages:   	Http Response: {"code":500,"detailedMessage":"json: cannot unmarshal string into Go struct field ListServiceAccountsResp.accounts of type madmin.ServiceAccountInfo","message":"an error occurred, please try again"}
--- FAIL: TestCreateServiceAccountForUser (0.55s)

[kaankabalak]

A failing test due to the server not having the support for the new data structure

&{500 Internal Server Error 500 HTTP/1.1 1 1 map[Content-Length:[199] Content-Type:[application/json] Date:[Tue, 30 May 2023 17:06:01 GMT] Server:[MinIO Console] Vary:[Accept-Encoding] X-Content-Type-Options:[nosniff] X-Frame-Options:[DENY] X-Xss-Protection:[1; mode=block]] 0xc000b96120 199 [] true false map[] 0xc00120e900 <nil>} <nil>
StatusCode: 500
    users_test.go:763: 
        	Error Trace:	/home/runner/work/console/console/integration/users_test.go:763
        	Error:      	Not equal: 
        	            	expected: 200
        	            	actual  : 500
        	Test:       	TestCreateServiceAccountForUser
        	Messages:   	Http Response: {"code":500,"detailedMessage":"json: cannot unmarshal string into Go struct field ListServiceAccountsResp.accounts of type madmin.ServiceAccountInfo","message":"an error occurred, please try again"}
    users_test.go:769: 
        	Error Trace:	/home/runner/work/console/console/integration/users_test.go:769
        	Error:      	Not equal: 
        	            	expected: 214
        	            	actual  : 40
        	Test:       	TestCreateServiceAccountForUser
        	Messages:   	Http Response: {"code":500,"detailedMessage":"json: cannot unmarshal string into Go struct field ListServiceAccountsResp.accounts of type madmin.ServiceAccountInfo","message":"an error occurred, please try again"}
--- FAIL: TestCreateServiceAccountForUser (0.55s)

Hi @harshavardhana, as stated here, the test is failing because it is using the latest minio which doesn't contain the changes in minio/minio#17249