List expiration dates for 'mc admin user svcacct list' command

[kaankabalak]

Description

This commit enables the user to list the expiration dates of the Service Accounts listed on the mc admin user svcacct list command.

Motivation and Context

As the user will be able to set the expiry of a Service Account on mc after PR #4570, it would also be practical for the users to see when they expire on the mc admin user svcacct list command.

Please merge this PR together with minio/madmin-go#195, minio/minio#17249 and minio/console#2824.

How to test this PR?

• Create service accounts with specified and unspecified expiry dates (The branch on Implement '--expiry' flag for 'mc admin user svcacct add & edit' #4570 can also be used for this)
• Replace the madmin-go module with the branch on Change ListServiceAccountsResp type madmin-go#195
• Run the MinIO Server as specified in Add expiration to ListServiceAccounts function minio#17249
• Use the mc admin user svcacct list ALIAS TARGET_ACCOUNT command and verify the Service Accounts and their expirations are listed as expected:

% ./mc admin user svcacct list ALIAS TARGET_ACCOUNT
   Access Key        | Expiry                       
5XF3ZHNZK6FBDWH9JMLX | 2023-06-24 07:00:00 +0000 UTC
F4V2BBUZSWY7UG96ED70 | 2023-12-24 18:00:00 +0000 UTC
FZVSEZ8NM9JRBEQZ7B8Q | no-expiry                    
HOXGL8ON3RG0IKYCHCUD | no-expiry                    

• For the case where there's no service accounts present, also use the mc admin user svcacct list ALIAS TARGET_ACCOUNT and make sure that Service Accounts aren't listed.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Optimization (provides speedup with no functional changes)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• Fixes a regression (If yes, please add commit-id or PR # here)
• Unit tests added/updated
• Internal documentation updated
• Create a documentation update request here

[kaankabalak]

Tests seem to be failing as we are not pointing to the minio/madmin-go#195 branch, @kannappanr could you advise me on how we move forward in these cases? Do we temporarily add a replace directive on go.mod that points to the branch, so that we can see if tests pass or not?

[shtripat]

LGTM. Verified with minio PR#17249

[kaankabalak]

Hi @harshavardhana, looks like we have 2 approving reviews, would it be possible to merge this and make a release so that I can update the packages for the other 2 PRs in minio/minio#17249 and minio/console#2824?

[vadmeste]

LGTM

[vadmeste]

@kaankabalak in fact we usually make sure to merge the changes in the server side first, just easier to manage and avoid users opening new tickets (users are expected to have mc version more recent than server version, that is why we follow this model)

[vadmeste]

Hi @harshavardhana, looks like we have 2 approving reviews, would it be possible to merge this and make a release so that I can update the packages for the other 2 PRs in minio/minio#17249 and minio/console#2824?

Oh you mean you are trying to resolve the dependency issue?

[kaankabalak]

Hi @harshavardhana, looks like we have 2 approving reviews, would it be possible to merge this and make a release so that I can update the packages for the other 2 PRs in minio/minio#17249 and minio/console#2824?

Oh you mean you are trying to resolve the dependency issue?

Yes 👍