Share File access key / secret key rollback #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
harshavardhana,
pjuarezd,
cniackz,
reivaj05,
cesnietor,
allanrogerr,
dvaldivia,
prakashsvmx,
kaankabalak,
kannappanr and
jinapurapu
dvaldivia
previously approved these changes
Jun 12, 2023
Signed-off-by: Benjamin Perez <benjamin@bexsoft.net>
reivaj05
approved these changes
Jun 12, 2023
cesnietor
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2844
What does this do?
Share File access key / secret key rollback in Share File screen
Motivation
There are some special cases where users don't have any Access Key / Secret Key available to sign files. In this case we will be doing rollback to this feature and tackle share file issue duration by doing some changes on MinIO server.
How does it look?