clarify MINIO_IDENTITY_OPENID_REDIRECT_URI and redirect_uri #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feorlen
changed the title
harshavardhana
approved these changes
Aug 14, 2023
ravindk89
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envvar
MINIO_IDENTITY_OPENID_REDIRECT_URIis apparently gone, although the correspondingidentity_openid redirect_urihas been deprecated but not removed. They were both noted as deprecated in the docs 1+ years ago.The recommended replacement is the envvar
MINIO_BROWSER_REDIRECT_URL, which does not appear to have a correspondingmc admin configsetting.This PR is an attempt to clarify the situation, feedback appreciated.
Staged
http://192.241.195.202:9000/staging/OPERATOR-1720/linux/html/reference/minio-mc-admin/mc-admin-config.html#mc-conf.identity_openid.redirect_uri
http://192.241.195.202:9000/staging/OPERATOR-1720/linux/html/reference/minio-server/minio-server.html#envvar.MINIO_IDENTITY_OPENID_REDIRECT_URI
See minio/operator#1722 and minio/operator#1720 for context.