-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OIDC: remove deprecated variable #1722
OIDC: remove deprecated variable #1722
Conversation
841e18b
to
ac3ea5e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
operator/api/tenant-add-handlers.go
Line 463 in 1557ba0
tenantConfigurationENV["MINIO_IDENTITY_OPENID_REDIRECT_URI"] = callbackURL |
operator/web-app/src/common/utils.ts
Line 786 in 1557ba0
"MINIO_IDENTITY_OPENID_REDIRECT_URI", |
Still have this
Thank you very much @jiuker I will also address those spots and re-test. |
ac3ea5e
to
1028f27
Compare
A question: does this mean |
Hello @feorlen, |
bffb6f1
to
579cce7
Compare
579cce7
to
2b00ca4
Compare
I have removed more spots. Tests have to pass then I ask for another round of reviews. |
The requested changes were completed, new review is required!.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Objectives:
MINIO_IDENTITY_OPENID_REDIRECT_URI
Related:
Documentation:
Testing: