kesconf: expose public API #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shtripat
reviewed
Nov 8, 2023
shtripat
approved these changes
Nov 9, 2023
This commit exposes kes server confguration API and provides a dev server. Now, the `github.com/minio/kes/kesconf` package exposes a stable API for reading the KES server configuration. This supersedes the `kv` package and removes the `edge` package. Further, the KES server provides the `--dev` flag to start a KES server in development mode with a in-memory keystore. The `--key`, `--cert` and `--auth` are deprecated. Users should use the config file to provide such config options. Signed-off-by: Andreas Auernhammer <github@aead.dev>
Signed-off-by: Andreas Auernhammer <github@aead.dev>
aead
force-pushed
the
kesconf-refactor
branch
from
1dc1e23 to
74f7a76
Compare
pjuarezd
added a commit
to pjuarezd/operator
that referenced
this pull request
Feb 22, 2024
…e used. A breaking change in config file is making Operator fail, Operator needs to handle the config across different KES config versions. minio/kes#414 Signed-off-by: pjuarezd <pjuarezd@users.noreply.github.com>
pjuarezd
added a commit
to pjuarezd/operator
that referenced
this pull request
Feb 22, 2024
…Operator fail, Operator needs to handle the KES config variations across different KES versions.
harshavardhana
pushed a commit
to minio/operator
that referenced
this pull request
Feb 23, 2024
…#1993) A breaking change (minio/kes#414) in KES command arguments is making Operator fail, Operator needs to handle the KES config variations across different KES versions.
|
@aead the --auth deprecation messages states:
However I have not found any documentation for how to set this flag inside the config file. Can you elaborate? It's a bit confusing right now trying to follow the official KES docs such as https://min.io/docs/kes/concepts/ as they still mention usig the --auth flag to bypass CA verification. Also note that all the various MinIO tutorials are using self signed certificates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes kes server confguration API and provides a dev server.
Now, the
github.com/minio/kes/kesconfpackage exposes a stable API for reading the KES server configuration. This supersedes thekvpackage and removes theedgepackage.Further, the KES server provides the
--devflag to start a KES server in development mode with a in-memory keystore. The--key,--certand--authare deprecated. Users should use the config file to provide such config options.