Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect KES version from image tag to Identify if v3 should be used. #1993

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

pjuarezd
Copy link
Member

@pjuarezd pjuarezd commented Feb 22, 2024

A breaking change in KES config file is making Operator fail, Operator needs to handle the config variations across different KES versions minio/kes#414.

KesConfigVersionN is an Operator level identifier for the KES config file, and command arguments that need to be provisioned for KES pods.

@pjuarezd pjuarezd changed the title Detect KES version from image tag to Identify if "version 3" should be used. Detect KES version from image tag to Identify if v3 should be used. Feb 22, 2024
@pjuarezd pjuarezd self-assigned this Feb 22, 2024
@pjuarezd
Copy link
Member Author

When complete this will fix broken test in #1991

@pjuarezd pjuarezd changed the title Detect KES version from image tag to Identify if v3 should be used. [WIP] Detect KES version from image tag to Identify if v3 should be used. Feb 22, 2024
…Operator fail, Operator needs to handle the KES config variations across different KES versions.
@pjuarezd pjuarezd changed the title [WIP] Detect KES version from image tag to Identify if v3 should be used. Detect KES version from image tag to Identify if v3 should be used. Feb 22, 2024
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a minor question

api/encryption-handlers.go Show resolved Hide resolved
Copy link
Contributor

@shtripat shtripat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@harshavardhana harshavardhana merged commit 54b8fc5 into minio:master Feb 23, 2024
26 checks passed
@pjuarezd pjuarezd deleted the kes-confg-changes branch February 24, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants